New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERROR: Read name line should start with '@' #491
Comments
Can you upload the data that failed? |
I am so glad that someone else ran into this problem! I have some examples because I'm running into the same issue with some paired-end SARS-CoV-2 files that I use for a lot of my testing. They are located at: |
The smoking gun is this:
When I decompress and recompress with I also decompressed and recompressed with |
@zerobio rooted it as you pointed. I will fix and update it soon. |
Please try v0.23.4 |
Binary at http://opengene.org/fastp/fastp is not updated yet. |
Yes, that will be updated tomorrow. |
Pre-built binary was just updated. But the conda version is still waiting for auto bump-up. |
Can confirm this issue is fixed in the latest version! |
Thank you very much!Yes,the issue isfixed. |
Confirms it works on |
- \r\n handling may cause reading a byte past end of buffer, parser fails - checking end-of-file condition can only be reliably done after a call to getLine() returns NULL. One particular case is that some gzip files contain empty gzip blocks at the end of the file, which can´t be predicted by the current eof() code Tested with files provided in issue OpenGene#491. This reverts commit 0ee1b3b, "fix a regression bug of FASTQ reader"
ERROR: Read name line should start with '@',I used fastp 0.23.3 to deal my data. But when I use fastp.0.23.0,it's not occured this ERROR。I think this version is missing to handling of these abnormal reads.Looking forward to your response.
The text was updated successfully, but these errors were encountered: