Parallel projection and discrete zoom #421
Conversation
Added parallel projection. Added discrete zoom. Pass some configuration into the renderers.
…nges in zoom definition. Clustering needs to know the size of the layer so that the scale can be appropriate, as the scale is now fixed to the zoom level rather than a combination of zoom level and window size.
Add selenium test for parallel projection. Add a little bit of documentation to the map class.
|
👏 |
|
Yay! I restarted the buildbot build. I have seen a couple of errors related to downloads from midas failing the last couple of days. I think it just some local network issues, hopefully they don't persist. |
|
I am reviewing the VGL branch first and then will get back to this one. |
|
I feel like I will need to get 5 or 6 demos of what's new in GeoJS when I get back in town. Great work @manthey @jbeezley @aashish24 @danlamanna! 🎉 |
| * autoResize: | ||
| * clampBounds: | ||
| * interactor: | ||
| * clock: |
There was a problem hiding this comment.
Yes, we should start documenting class options like this.
| @@ -1,4 +1,6 @@ | |||
| /build/* | |||
| /_build/* | |||
| /Testing/* | |||
There was a problem hiding this comment.
My filesystem isn't case sensitive, so this ignores all files under testing. :(
jbeezley
force-pushed
the
parallel-projection
branch
from
a0e0985
to
d8892bd
Compare
jbeezley
force-pushed
the
parallel-projection
branch
from
d8892bd
to
b010ad6
Compare
|
@jbeezley I didn't have any major questions here. Feel free to merge it if it looks good to you. |
|
@manthey Great stuff.. 👏 |
|
As you noted, the discrete zoom feature doesn't work well with touch events, but we can treat it as an experimental feature and open a separate issue for it.
|
Parallel projection and discrete zoom
|
Thanks, @jbeezley for dealing with the Selenium tests. |
|
Penance for designing them. |
|
@jbeezley nice approval image! .... 👍 |
Added parallel projection and discrete zoom.
Zoom levels are now consistent with other mapping libraries and are no longer based on the window size. As such, the zoom level is DIFFERENT from what it was, unless the window was exactly one standard map tile high (256 pixels).
Pass some configuration into the renderers.
Update tests to have better window resizing and to compensate for changes in zoom definition. This breaks all of the screen shot tests.
Clustering needs to know the size of the layer so that the scale can be appropriate, as the scale is now fixed to the zoom level rather than a combination of zoom level and window size.
Add jasmine test for discrete zoom and parallel projection. Add selenium test for parallel projection.
Add a little bit of documentation to the map class.