Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess we extensively use constructs like this:
as shorthand for
I was never 100% sure that the former was legal, but the compilers didn't
complain and I preferred it over the more verbose equivalent.
But apparently, it's just lax compilers, and in the latest Clang 3.9,
doing this (assuming "expansion to defined") is a warning, and of course
we usually treat warnings as errors.
It's going to be a lot of work to track all of these down and fix them,
especially before clang 3.9 has a Homebrew package (without it, I'm
operating blind, both on my laptop and on the TravisCI builds). So for
now, we'll settle for just disabling that warning, and slowly fix up the
guards later.