Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Make the status bar icon reflect the strength of the connected network #46

Closed
igorkulman opened this issue Jul 3, 2020 · 0 comments · Fixed by #47
Closed

[Feature Request] Make the status bar icon reflect the strength of the connected network #46

igorkulman opened this issue Jul 3, 2020 · 0 comments · Fixed by #47
Labels
enhancement New feature or request
Milestone
v1.0.0

Comments

@igorkulman
Copy link
Contributor

Is your feature request related to a problem? Please describe.
After #37 is merged and #43 fixed it should be possible to make the status bar icon show the real strength of the Wifi signal if a network is connected

Describe the solution you'd like
If connected to a Wifi network, the status bar icon should show the real strength of the connection.
@williambj1 williambj1 added the enhancement New feature or request label Jul 4, 2020
@williambj1 williambj1 added this to the v1.0.0 milestone Jul 4, 2020
ErrorErrorError added a commit to ErrorErrorError/HeliPort that referenced this issue Jul 5, 2020
@ErrorErrorError
Fixes Wi-Fi status icon from showing off after turning on WiFi card.
c268ad3 
- Status bar correctly reflects the strength of the connected network.
- closes this issue OpenIntelWireless#46
-  `getRssiImage(_ RSSI: Int) -> NSImage?` is now a class function and can now be called in `StatusBarIconManager` to detect wifi rssi state
- debating whether or not to remove `StatusBarIcon.connecting()` from `NetworkInfo.swift` since the state should be the one figuring that out when is scanning but as of now it is not fixed in itlwm. More info here: OpenIntelWireless/itlwm#160
@ErrorErrorError ErrorErrorError mentioned this issue Jul 5, 2020
Merged
@williambj1 williambj1 linked a pull request Jul 5, 2020 that will close this issue
Status bar correctly reflects the strength of the connected network #47
Merged
ErrorErrorError added a commit to ErrorErrorError/HeliPort that referenced this issue Jul 5, 2020
@ErrorErrorError
Fixes Wi-Fi status icon from showing off after turning on WiFi card.
b5dbb5f 
- Status bar correctly reflects the strength of the connected network.
- closes this issue OpenIntelWireless#46
-  `getRssiImage(_ RSSI: Int) -> NSImage?` is now a class function and can now be called in `StatusBarIconManager` to detect wifi rssi state
- debating whether or not to remove `StatusBarIcon.connecting()` from `NetworkInfo.swift` since the state should be the one figuring that out when is scanning but as of now it is not fixed in itlwm. More info here: OpenIntelWireless/itlwm#160

- Fixed issue where `StatusBarIcon` kept flickering
- set initial `StatusBarIcon` as off so it can be consistent with `isNetworkEnabled`
- only update `StatusBarIcon` from `isNetworkEnabled` if there is a change in value to prevent flickering

- Fixes issue with no items showing when status is `Wi-Fi: Connected`
- checks the state of the network card when the app is first run and sets the correct state OpenIntelWireless#45
- fixed an issue where the network info did not updated when option menu is pressed. Now every time network list updates, it also updates the information of connected network, if any.
@Goshin Goshin closed this as completed in #47 Jul 7, 2020
Goshin pushed a commit that referenced this issue Jul 7, 2020
@ErrorErrorError
Fixes Wi-Fi status icon from showing off after turning on WiFi card. (#…
a60301b 
…47)

- Status bar correctly reflects the strength of the connected network.
- closes this issue #46
-  `getRssiImage(_ RSSI: Int) -> NSImage?` is now a class function and can now be called in `StatusBarIconManager` to detect wifi rssi state
- debating whether or not to remove `StatusBarIcon.connecting()` from `NetworkInfo.swift` since the state should be the one figuring that out when is scanning but as of now it is not fixed in itlwm. More info here: OpenIntelWireless/itlwm#160

- Fixed issue where `StatusBarIcon` kept flickering
- set initial `StatusBarIcon` as off so it can be consistent with `isNetworkEnabled`
- only update `StatusBarIcon` from `isNetworkEnabled` if there is a change in value to prevent flickering

- Fixes issue with no items showing when status is `Wi-Fi: Connected`
- checks the state of the network card when the app is first run and sets the correct state #45
- fixed an issue where the network info did not updated when option menu is pressed. Now every time network list updates, it also updates the information of connected network, if any.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Status bar correctly reflects the strength of the connected network ErrorErrorError/HeliPort
2 participants
@igorkulman @williambj1