Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[新バージョン対応] グラフ彩色問題 #416

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

github-nakasho
Copy link
Collaborator

Changes

グラフ彩色問題を題材にしたOpenJijチュートリアル文章を、最近のJijModeling, Jijtranspilerに対応させたものに改訂しました。

Related issue

https://github.com/Jij-Inc/JijZeptIssues/issues/191

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.09%. Comparing base (106bc52) to head (51368d6).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files          42       42           
  Lines        2567     2567           
  Branches      925      925           
=======================================
  Hits         1902     1902           
  Misses        379      379           
  Partials      286      286           
Flag Coverage Δ
openjij 67.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@NY57 NY57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024/3/25 9:00 JST時点のレビューを行いました。
2点、Suggestionを出させていただきましたので、ご確認お願いします。

docs/tutorial/ja/optimization/graph_coloring.md Outdated Show resolved Hide resolved
docs/tutorial/ja/optimization/graph_coloring.md Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Apr 9, 2024

Code Climate has analyzed commit 51368d6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.2% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@NY57 NY57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございました!Approveさせて頂きます!

@NY57 NY57 merged commit fbf5c6f into main Apr 9, 2024
25 checks passed
@NY57 NY57 deleted the feature/graph_coloring branch April 9, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants