New hooks in FileParsers #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a plugin example of these added hooks in use: http://pastebin.com/84X3rjny They seem to work fine and were tested by me. |
|
@snop222 Did you test these changes in game before merging them? http://forums.openkore.com/viewtopic.php?f=6&t=211255&p=273514#p273514 |
|
Ah, Sorry !! Very Sorry !! I think I had a mistake !! I just want to try the "Merge Pull Request". PS: I think, I do only one "Merge", but merging two "Pull Request" !! |
|
I think it's fine to keep this merged. It creates two new hooks which nobody will have been using, and if nobody uses them, the old functionality is maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a request to add 2 new hooks in FileParsers::updatePortalLUT2
and FileParsers::updatePortalLUT. The purpose is to add support for
plugin related custom portal file updating.