-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contract testing guide #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin0
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
austin0
added a commit
that referenced
this pull request
Jan 7, 2021
* Changed dir names (#133) Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Changing name of the example files to match with actual files in guides repos (#135) * Changed dir names * Changed file name of the examples Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Updated by github actions from guide-microprofile-config (#145) Co-authored-by: GuidesBot <GuidesBot@OpenLiberty.io> * Changing title of PR's that are created by the action (#151) * Changed dir names * Changed file name of the examples * Changing title of PR's that are created by the action Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Adding Guide-containerize (#154) Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Updating actions to clone Guides and run GuideConverter locally (#156) * Adding Guide-containerize * added cloud hosted * Editted actions to work with local files instead of using Github API * Actions functionality for GuideConverter to run on cloned files instead of Github API * fixing command to delete GuideConverter repo after action finishes (draftGuideAction) * Removed weird indent from line 31 Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Fixing issue with PR to staging (#175) Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Add support for various branch name on guide repositories (#208) * Add support for various branch names on guide repositories Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Update to support new guide converter Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Add contract testing guide (#212) * Remove guide containerize (#219) Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Fix containerize mirror.yml (#220) Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Fix containerize on staging branch Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> Co-authored-by: jakub-pomykala <56261244+jakub-pomykala@users.noreply.github.com> Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GuidesBot <GuidesBot@OpenLiberty.io> Co-authored-by: Meswan Bhaugeerutty <meswan@ca.ibm.com>
austin0
added a commit
that referenced
this pull request
Jan 18, 2021
* Changed dir names (#133) Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Changing name of the example files to match with actual files in guides repos (#135) * Changed dir names * Changed file name of the examples Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Updated by github actions from guide-microprofile-config (#145) Co-authored-by: GuidesBot <GuidesBot@OpenLiberty.io> * Changing title of PR's that are created by the action (#151) * Changed dir names * Changed file name of the examples * Changing title of PR's that are created by the action Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Adding Guide-containerize (#154) Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Updating actions to clone Guides and run GuideConverter locally (#156) * Adding Guide-containerize * added cloud hosted * Editted actions to work with local files instead of using Github API * Actions functionality for GuideConverter to run on cloned files instead of Github API * fixing command to delete GuideConverter repo after action finishes (draftGuideAction) * Removed weird indent from line 31 Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Fixing issue with PR to staging (#175) Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Add support for various branch name on guide repositories (#208) * Add support for various branch names on guide repositories Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Update to support new guide converter Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Add contract testing guide (#212) * Remove guide containerize (#219) Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Fix containerize mirror.yml (#220) Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Fixing DraftConverter Action (#224) Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Remove draft-guide-contract testing from master Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Adding new conversion testing action (#234) Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> * Add draft-guide-contract testing to staging Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Revert "Add draft-guide-contract testing to staging" This reverts commit 4e381e1. * Remove draft-guide-contract testing from master (#235) * Remove draft-guide-contract testing from master Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Add draft-guide-contract testing to staging Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> * Revert "Add draft-guide-contract testing to staging" This reverts commit 4e381e1. * Prepare repo for rename to 'cloud-hosted-guides' Signed-off-by: Austin Bailey <Austin.Bailey@ibm.com> Co-authored-by: jakub-pomykala <56261244+jakub-pomykala@users.noreply.github.com> Co-authored-by: Jakub F Pomykala <Jakub.Pomykala@ibm.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GuidesBot <GuidesBot@OpenLiberty.io> Co-authored-by: Meswan Bhaugeerutty <meswan@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.