Red Hat cert requires that images not be run as root #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of root user in Dockerfile Signed-off-by: Andrew J. Mauer <ajmauer@gmail.com>
ajm01
force-pushed
the
eliminate-use-of-root-user
branch
3 times, most recently
from
4b9a30a
to
45b6343
Compare
Signed-off-by: Andrew J. Mauer <ajmauer@gmail.com>
ajm01
force-pushed
the
eliminate-use-of-root-user
branch
from
45b6343
to
5cafb7d
Compare
Signed-off-by: Andrew J. Mauer <ajmauer@gmail.com>
scottkurz
requested changes
Oct 8, 2020
baseimage/Dockerfile
Outdated
|
|
||
| USER java_user | ||
|
|
||
| RUN chmod -R 755 /stacks/java-openliberty/starterapp |
There was a problem hiding this comment.
I don't think you need a chmod here... java_user is the owner
Signed-off-by: Andrew J. Mauer <ajmauer@gmail.com>
scottkurz
reviewed
Oct 8, 2020
| WORKDIR /stacks/java-openliberty/starterapp | ||
| USER java_user | ||
|
|
||
| RUN chmod -R 755 /stacks/java-openliberty/priming-app |
There was a problem hiding this comment.
Don't think we need this since java_user already owns this. But this is an empty dir, so probably not worth respinning.
scottkurz
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eliminate usage of root user in Dockerfile/base image
Fixes #71