Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the travis test #17

Merged
merged 6 commits into from
Jul 23, 2020
Merged

Fix the travis test #17

merged 6 commits into from
Jul 23, 2020

Conversation

gkwan-ibm
Copy link
Member

@gkwan-ibm gkwan-ibm commented Jul 23, 2020 •
edited
Loading

travis test failed because the path in Linux is case-sensitive. 2 js files pointed incorrectly.
Also, remove the .DS_Store files

@gkwan-ibm gkwan-ibm requested a review from salmad3 July 23, 2020 14:24
salmad3
salmad3 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gkwan-ibm gkwan-ibm merged commit 242bb4c into qa Jul 23, 2020
@salmad3 salmad3 mentioned this pull request Jul 23, 2020
Closed
@gkwan-ibm gkwan-ibm mentioned this pull request Jul 23, 2020
Merged
@gkwan-ibm gkwan-ibm deleted the gkwan-ibm-patch-3 branch July 23, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salmad3 salmad3 salmad3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkwan-ibm @salmad3