Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up changes for fixing RepositoryResolver install lists for tolerated dependencies #19963

Merged
merged 3 commits into from
Jan 29, 2022
Merged

Follow-up changes for fixing RepositoryResolver install lists for tolerated dependencies #19963

merged 3 commits into from
Jan 29, 2022

Commits on Jan 28, 2022

  1. List installed features in resolver unit test 

    Correct the starting scenario by listing all the features which are
meant to be installed.
    @Azquelt
    Azquelt committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    7d64457 View commit details
    Browse the repository at this point in the history

  2. Resolver: remove redundant checks 

    The sets featuresMissing and requirementsFoundForOtherProducts are
disjoint. If we're checking that featuresMissing contains a feature
name, we don't need to also check that requirementsFoundForOtherProducts
doesn't contain it.

Previously we just had a check to ensure it wasn't in
requirementsFoundForOtherProducts. This wasn't correct either as it's
possible for the feature to be in neither set if it conflicted with
another feature.
    @Azquelt
    Azquelt committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    701fa13 View commit details
    Browse the repository at this point in the history

  3. Update resolver test copyright years 

    The copyright headers should have been updated in OpenLiberty#19871
    @Azquelt
    Azquelt committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    af54d8a View commit details
    Browse the repository at this point in the history