Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some broken links #1089

Merged
merged 4 commits into from
Oct 21, 2019
Merged

Fix some broken links #1089

merged 4 commits into from
Oct 21, 2019

Conversation

FloEdelmann
Copy link
Member

  • Replace some failing links with more recent alternatives
  • Increase link fetch timeout (10s → 30s) to make timeout failures less likely

References #999.

@FloEdelmann FloEdelmann added bug Something doesn't work as intended. component-fixture Affects one or more existing fixture definitions. labels Oct 21, 2019
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1089 October 21, 2019 20:59 Inactive
@FloEdelmann
Copy link
Member Author

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ cameo / auro-spot-300: d-light / attributes-correctness
  • ✔️ cameo/auro-spot-300-5ch.xml
  • ✔️ cameo/auro-spot-300-15ch.xml
  • ✔️ cameo/auro-spot-300-24ch.xml
✔️ cameo / auro-spot-300: millumin / json-schema-conformity
  • ✔️ cameo/auro-spot-300.json
✔️ cameo / auro-spot-300: qlcplus_4.11.2 / xsd-schema-conformity
  • ✔️ cameo-Auro-Spot-300.qxf
✔️ cameo / auro-spot-300: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ cameo-Auro-Spot-300.qxf
✔️ cameo / auro-spot-300: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ cameo-Auro-Spot-300.qxf
✔️ dedolight / dled4-bi: d-light / attributes-correctness
  • ✔️ dedolight/dled4-bi-DT4-BI-DMX.xml
✔️ dedolight / dled4-bi: millumin / json-schema-conformity
  • ✔️ dedolight/dled4-bi.json
✔️ dedolight / dled4-bi: qlcplus_4.11.2 / xsd-schema-conformity
  • ✔️ Dedolight-DLED4-BI.qxf
✔️ dedolight / dled4-bi: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ Dedolight-DLED4-BI.qxf
✔️ dedolight / dled4-bi: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ Dedolight-DLED4-BI.qxf
✔️ dedolight / dled7-bi: d-light / attributes-correctness
  • ✔️ dedolight/dled7-bi-DT7-BI-DMX.xml
✔️ dedolight / dled7-bi: millumin / json-schema-conformity
  • ✔️ dedolight/dled7-bi.json
✔️ dedolight / dled7-bi: qlcplus_4.11.2 / xsd-schema-conformity
  • ✔️ Dedolight-DLED7-BI.qxf
✔️ dedolight / dled7-bi: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ Dedolight-DLED7-BI.qxf
✔️ dedolight / dled7-bi: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ Dedolight-DLED7-BI.qxf
✔️ magicfx / psyco2jet: d-light / attributes-correctness
  • ✔️ magicfx/psyco2jet-Safety.xml
  • ✔️ magicfx/psyco2jet-Raw.xml
  • ✔️ magicfx/psyco2jet-Preset.xml
✔️ magicfx / psyco2jet: millumin / json-schema-conformity
  • ✔️ magicfx/psyco2jet.json
✔️ magicfx / psyco2jet: qlcplus_4.11.2 / xsd-schema-conformity
  • ✔️ MagicFX-PSYCO2JET.qxf
✔️ magicfx / psyco2jet: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ MagicFX-PSYCO2JET.qxf
✔️ magicfx / psyco2jet: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ MagicFX-PSYCO2JET.qxf
✔️ magicfx / stage-flame: d-light / attributes-correctness
  • ✔️ magicfx/stage-flame-Default.xml
✔️ magicfx / stage-flame: millumin / json-schema-conformity
  • ✔️ magicfx/stage-flame.json
✔️ magicfx / stage-flame: qlcplus_4.11.2 / xsd-schema-conformity
  • ✔️ MagicFX-Stage-Flame.qxf
✔️ magicfx / stage-flame: qlcplus_4.12.1 / fixture-tool-validation
  • ✔️ MagicFX-Stage-Flame.qxf
✔️ magicfx / stage-flame: qlcplus_4.12.1 / xsd-schema-conformity
  • ✔️ MagicFX-Stage-Flame.qxf

@FloEdelmann
Copy link
Member Author

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can view your uncommitted changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin-key> [-c <compare-plugin-key>] <fixtures>

💤 cameo/auro-spot-300: d-light Outputted files not changed.
💤 cameo/auro-spot-300: ecue Outputted files not changed.
🆚 cameo/auro-spot-300: millumin
Changed outputted file cameo/auro-spot-300.json 
--- removed
+++ added
@@ -7,9 +7,9 @@
     "authors": ["Felix Edelmann"],
     "createDate": "2019-02-08",
     "lastModifyDate": "2019-02-08"
   },
-  "manualURL": "https://adamhall.s3.amazonaws.com/media/MARKEN/CAMEO/CLAS300/CLAS300_CAMEO_Bedienungsanleitung_EN_DE_FR_ES_PL_IT.PDF",
+  "manualURL": "https://www.adamhall.com/shop/us-en/downloads/file/id/-354715156",
   "physical": {
     "dimensions": [285, 485, 180],
     "weight": 8.75,
     "power": 320,
💤 cameo/auro-spot-300: op-z Outputted files not changed.
💤 cameo/auro-spot-300: qlcplus_4.11.2 Outputted files not changed.
💤 cameo/auro-spot-300: qlcplus_4.12.1 Outputted files not changed.
💤 dedolight/dled4-bi: d-light Outputted files not changed.
🆚 dedolight/dled4-bi: ecue
Changed outputted file UserLibrary.xml 
--- removed
+++ added
@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <Document Owner="user" TypeVersion="2" SaveTimeStamp="2019-10-21#21:11:17">
     <Library>
         <Fixtures>
-            <Manufacturer _CreationDate="2019-10-21#21:11:17" _ModifiedDate="2019-10-21#21:11:17" Name="Dedolight" Comment="" Web="http://www.dedolight.com">
+            <Manufacturer _CreationDate="2019-10-21#21:11:17" _ModifiedDate="2019-10-21#21:11:17" Name="Dedolight" Comment="" Web="https://www.dedoweigertfilm.de/dwf-en/brands/dedolight_overview.php">
                 <Fixture _CreationDate="2018-11-11#00:00:00" _ModifiedDate="2018-11-11#00:00:00" Name="DLED4-BI" NameShort="DLED4-BI" Comment="The DT4-BI-DMX power supply is needed for DMX control. (generated by the Open Fixture Library – https://open-fixture-library.org/dedolight/dled4-bi)" AllocateDmxChannels="2" Weight="1.3" Power="47" DimWidth="109" DimHeight="200" DimDepth="100">
                     <ChannelIntensity Name="Dimmer" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="1">
                         <Range Name="Intensity off…bright" Start="0" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelIntensity>
@@ -13,8 +13,8 @@
                 </Fixture>
             </Manufacturer>
         </Fixtures>
         <Tiles>
-            <Manufacturer _CreationDate="2019-10-21#21:11:17" _ModifiedDate="2019-10-21#21:11:17" Name="Dedolight" Comment="" Web="http://www.dedolight.com"/>
+            <Manufacturer _CreationDate="2019-10-21#21:11:17" _ModifiedDate="2019-10-21#21:11:17" Name="Dedolight" Comment="" Web="https://www.dedoweigertfilm.de/dwf-en/brands/dedolight_overview.php"/>
         </Tiles>
     </Library>
 </Document>
\ No newline at end of file
💤 dedolight/dled4-bi: millumin Outputted files not changed.
💤 dedolight/dled4-bi: op-z Outputted files not changed.
💤 dedolight/dled4-bi: qlcplus_4.11.2 Outputted files not changed.
💤 dedolight/dled4-bi: qlcplus_4.12.1 Outputted files not changed.
💤 dedolight/dled7-bi: d-light Outputted files not changed.
🆚 dedolight/dled7-bi: ecue
Changed outputted file UserLibrary.xml 
--- removed
+++ added
@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <Document Owner="user" TypeVersion="2" SaveTimeStamp="2019-10-21#21:11:20">
     <Library>
         <Fixtures>
-            <Manufacturer _CreationDate="2019-10-21#21:11:20" _ModifiedDate="2019-10-21#21:11:20" Name="Dedolight" Comment="" Web="http://www.dedolight.com">
+            <Manufacturer _CreationDate="2019-10-21#21:11:20" _ModifiedDate="2019-10-21#21:11:20" Name="Dedolight" Comment="" Web="https://www.dedoweigertfilm.de/dwf-en/brands/dedolight_overview.php">
                 <Fixture _CreationDate="2018-12-19#00:00:00" _ModifiedDate="2018-12-19#00:00:00" Name="DLED7-BI" NameShort="DLED7-BI" Comment="The DT7-BI-DMX power supply is needed for DMX control. (generated by the Open Fixture Library – https://open-fixture-library.org/dedolight/dled7-bi)" AllocateDmxChannels="2" Weight="1.3" Power="90" DimWidth="109" DimHeight="200" DimDepth="100">
                     <ChannelIntensity Name="Dimmer" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="1" Invert="0" Precedence="LTP" ClassicPos="1">
                         <Range Name="Intensity off…bright" Start="0" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelIntensity>
@@ -13,8 +13,8 @@
                 </Fixture>
             </Manufacturer>
         </Fixtures>
         <Tiles>
-            <Manufacturer _CreationDate="2019-10-21#21:11:20" _ModifiedDate="2019-10-21#21:11:20" Name="Dedolight" Comment="" Web="http://www.dedolight.com"/>
+            <Manufacturer _CreationDate="2019-10-21#21:11:20" _ModifiedDate="2019-10-21#21:11:20" Name="Dedolight" Comment="" Web="https://www.dedoweigertfilm.de/dwf-en/brands/dedolight_overview.php"/>
         </Tiles>
     </Library>
 </Document>
\ No newline at end of file
🆚 dedolight/dled7-bi: millumin
Changed outputted file dedolight/dled7-bi.json 
--- removed
+++ added
@@ -7,9 +7,8 @@
     "createDate": "2018-12-19",
     "lastModifyDate": "2018-12-19"
   },
   "comment": "The DT7-BI-DMX power supply is needed for DMX control.",
-  "helpWanted": "The Dedolight website does not contain an official product page for this fixture. Can you provide the link to a reliable data sheet / manual / product page?",
   "physical": {
     "dimensions": [109, 200, 100],
     "weight": 1.3,
     "power": 90,
💤 dedolight/dled7-bi: op-z Outputted files not changed.
💤 dedolight/dled7-bi: qlcplus_4.11.2 Outputted files not changed.
💤 dedolight/dled7-bi: qlcplus_4.12.1 Outputted files not changed.
💤 magicfx/psyco2jet: d-light Outputted files not changed.
💤 magicfx/psyco2jet: ecue Outputted files not changed.
💤 magicfx/psyco2jet: millumin Outputted files not changed.
💤 magicfx/psyco2jet: op-z Outputted files not changed.
💤 magicfx/psyco2jet: qlcplus_4.11.2 Outputted files not changed.
💤 magicfx/psyco2jet: qlcplus_4.12.1 Outputted files not changed.
💤 magicfx/stage-flame: d-light Outputted files not changed.
💤 magicfx/stage-flame: ecue Outputted files not changed.
💤 magicfx/stage-flame: millumin Outputted files not changed.
💤 magicfx/stage-flame: op-z Outputted files not changed.
💤 magicfx/stage-flame: qlcplus_4.11.2 Outputted files not changed.
💤 magicfx/stage-flame: qlcplus_4.12.1 Outputted files not changed.

@FloEdelmann FloEdelmann merged commit a2c5ecf into master Oct 21, 2019
@FloEdelmann FloEdelmann deleted the fix-links branch October 21, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxedel fxedel fxedel approved these changes

Assignees
No one assigned
Labels
bug Something doesn't work as intended. component-fixture Affects one or more existing fixture definitions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FloEdelmann @fxedel