Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some broken links #1089

Merged
merged 4 commits into from
Oct 21, 2019
Merged

Fix some broken links #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7866884
Fix some broken links
FloEdelmann Oct 21, 2019
b788940
Increase external link fetch timeout to 30s
FloEdelmann Oct 21, 2019
dd9cfe7
Actually increase timeout to 30s...
FloEdelmann Oct 21, 2019
114caf8
Merge branch 'master' into fix-links
FloEdelmann Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fixtures/cameo/auro-spot-300.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
},
"links": {
"manual": [
"https://adamhall.s3.amazonaws.com/media/MARKEN/CAMEO/CLAS300/CLAS300_CAMEO_Bedienungsanleitung_EN_DE_FR_ES_PL_IT.PDF"
"https://www.adamhall.com/shop/us-en/downloads/file/id/-354715156"
],
"productPage": [
"https://www.cameolight.com/en/solutions/dj-musicians/moving-lights/moving-heads/2074/auro-spot-300"
"https://www.adamhall.com/shop/us-en/archiv/2074/auro-spot-300?c=5621"
]
},
"physical": {
Expand Down
6 changes: 2 additions & 4 deletions fixtures/dedolight/dled4-bi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@
"comment": "The DT4-BI-DMX power supply is needed for DMX control.",
"links": {
"productPage": [
"http://www.dedolight.com/dedolight/default.php?la=0&pg=00000400100507&id=DL-DLED4-BI&section=0",
"http://www.dedolight.com/dedolight/default.php?la=0&pg=00000400100616&id=DL-DT4-BI-DMX&section=0"
"https://www.dedoweigertfilm.de/dwf-en/products/dedolight/dedolight-dled-series4.php"
],
"other": [
"http://www.dedolight.com/assets/pdf/DLED4-technical-data.pdf",
"http://www.dedolight.com/assets/pdf/PowerSupply-DLED4-technical-data.pdf"
"https://www.mediatec.de/media/pdf/fa/f8/cb/DLED4_DATENBLATT_0005.pdf"
]
},
"physical": {
Expand Down
6 changes: 4 additions & 2 deletions fixtures/dedolight/dled7-bi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@
"lastModifyDate": "2018-12-19"
},
"comment": "The DT7-BI-DMX power supply is needed for DMX control.",
"helpWanted": "The Dedolight website does not contain an official product page for this fixture. Can you provide the link to a reliable data sheet / manual / product page?",
"links": {
"productPage": [
"https://www.dedoweigertfilm.de/dwf-en/home_banner_prod/turbo-series.php"
],
"other": [
"https://www.teltec.de/dedolight-dled7-bi.html"
"https://www.mediatec.de/media/pdf/04/d6/8c/TURBO_SERIE_BROSCHUERE_0005.pdf"
]
},
"physical": {
Expand Down
2 changes: 1 addition & 1 deletion fixtures/magicfx/psyco2jet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"https://www.magicfx.eu/media/mconnect_uploadfiles/m/a/magicfx-psyco2jet-manual.pdf"
],
"productPage": [
"https://www.magicfx.eu/hardware/co2-fx/psyco2jet-1855"
"https://www.magicfx.eu/hardware/co2-fx/psyco2jet-1858"
],
"video": [
"https://www.youtube.com/watch?v=l9QZ8UaUbmg",
Expand Down
2 changes: 1 addition & 1 deletion fixtures/magicfx/stage-flame.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"https://www.magicfx.eu/media/mconnect_uploadfiles/m/a/magicfx_stage_flame_manual.pdf"
],
"productPage": [
"https://www.magicfx.eu/hardware/flame-fx/magicfx-stage-flame-1857"
"https://www.magicfx.eu/hardware/flame-fx/magicfx-stage-flame-1860"
],
"video": [
"https://www.youtube.com/watch?v=YLeYRexsTmc",
Expand Down
2 changes: 1 addition & 1 deletion fixtures/manufacturers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
},
"dedolight": {
"name": "Dedolight",
"website": "http://www.dedolight.com"
"website": "https://www.dedoweigertfilm.de/dwf-en/brands/dedolight_overview.php"
},
"dts": {
"name": "DTS",
Expand Down
3 changes: 2 additions & 1 deletion tests/external-links.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ require(`../lib/load-env-file.js`);

const USER_AGENT = require(`default-user-agent`)();
const GITHUB_COMMENT_HEADING = `## Broken links update`;
const TIMEOUT = 30000;

const SiteCrawler = require(`../lib/site-crawler.js`);

Expand Down Expand Up @@ -153,7 +154,7 @@ async function testExternalLink(url) {
headers: {
'user-agent': USER_AGENT
},
timeout: 10000
timeout: TIMEOUT
};

return new Promise((resolve, reject) => {
Expand Down