Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture philips-showline/sl-e-stripe-10 #3854

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture philips-showline/sl-e-stripe-10

Fixture warnings / errors

  • philips-showline/sl-e-stripe-10
    • ❌ File does not match schema: fixture/matrix/pixelCount/0 -Infinity must be >= 1
    • ❌ File does not match schema: fixture/matrix/pixelCount/1 -Infinity must be >= 1
    • ❌ File does not match schema: fixture/templateChannels must NOT have fewer than 1 properties
    • ⚠️ Please check if manufacturer is correct and add manufacturer URL.
    • ⚠️ Please check 16bit channel 'Red_1 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Green_1 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Blue_1 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Red_2 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Green_2 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Blue_2 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Green_3 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Blue_3 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Green_4 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Blue_4 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Green_5 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Green_6 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Green_7 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Green_8 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Green_9 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Green_10- Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'White_1 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'White_2 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'White_3 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'White_4 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'White_5 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'White_6 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'White_7 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'White_8 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'White_9 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'White_10 - Low Byte': The corresponding coarse channel could not be detected.
    • ⚠️ Please add 16 Bit - 10 Pixel mode's Head initial structure #1 to the fixture's matrix. The included channels were Red_1 - High Byte, Red_1 - Low Byte, Green_1 - High Byte, Green_1 - Low Byte, Blue_1 - High Byte, Blue_1 - Low Byte, White_1 - Low Byte, White_1 - High Byte.
    • ⚠️ Please add 16 Bit - 10 Pixel mode's Head Initial styling #2 to the fixture's matrix. The included channels were Red_2 - High Byte, Red_2 - Low Byte, Green_2 - High Byte, Green_2 - Low Byte, Blue_2 - High Byte, Blue_2 - Low Byte, White_2 - High Byte, White_2 - Low Byte.
    • ⚠️ Please add 16 Bit - 10 Pixel mode's Head Add meaningful tests #3 to the fixture's matrix. The included channels were Red_3 - High Byte, Red_3 - Low Byte, Green_3 - High Byte, Green_3 - Low Byte, Blue_3 - High Byte, Blue_3 - Low Byte, White_3 - High Byte, White_3 - Low Byte.
    • ⚠️ Please add 16 Bit - 10 Pixel mode's Head make UI responsive #4 to the fixture's matrix. The included channels were Red_4 - High Byte, Red_4 - Low Byte, Green_4 - High Byte, Green_4 - Low Byte, Blue_4 - High Byte, Blue_4 - Low Byte, White_4 - Low Byte, White_4 - High Byte.
    • ⚠️ Please add 16 Bit - 10 Pixel mode's Head Fixtures can be viewed #5 to the fixture's matrix. The included channels were Red_5 - High Byte, Red_5 - Low Byte, Green_5 - High Byte, Green_5 - Low Byte, Blue_5 - High Byte, Blue_5 - Low Byte, White_5 - High Byte, White_5 - Low Byte.
    • ⚠️ Please add 16 Bit - 10 Pixel mode's Head Improved README.md #6 to the fixture's matrix. The included channels were Red_6 - High Byte, Red_6 - Low Byte, Green_6 - High Byte, Green_6 - Low Byte, Blue_6 - High Byte, Blue_6 - Low Byte, White_6 - High Byte, White_6 - Low Byte.
    • ⚠️ Please add 16 Bit - 10 Pixel mode's Head display all fixture infos #7 to the fixture's matrix. The included channels were Red_7 - High Byte, Red_7 - Low Byte, Green_7 - High Byte, Green_7 - Low Byte, Blue_7 - High Byte, Blue_7 - Low Byte, White_7 - High Byte, White_7 - Low Byte.
    • ⚠️ Please add 16 Bit - 10 Pixel mode's Head Problem with relative urls when index.js is not executed from same directory #8 to the fixture's matrix. The included channels were Red_8 - High Byte, Red_8 - Low Byte, Green_8 - High Byte, Green_8 - Low Byte, Blue_8 - High Byte, Blue_8 - Low Byte, White_8 - High Byte, White_8 - Low Byte.
    • ⚠️ Please add 16 Bit - 10 Pixel mode's Head use custom module.export js renderer #9 to the fixture's matrix. The included channels were Red_9 - High Byte, Red_9 - Low Byte, Green_9 - High Byte, Green_9 - Low Byte, Blue_9 - High Byte, Blue_9 - Low Byte, White_9 - High Byte, White_9 - Low Byte.
    • ⚠️ Please add 16 Bit - 10 Pixel mode's Head fix relative path being dependent on working directory #10 to the fixture's matrix. The included channels were Red_10 - High Byte, Red_10 - Low Byte, Green_10 - High Byte, Green_10- Low Byte, Blue_10 - High Byte, Blue_10 - Low Byte, White_10 - High Byte, White_10 - Low Byte.

User comment

only 16Bit 10 Pixel Mode
No Dimensions

Thank you MoritzMHHD!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Mar 17, 2024
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ philips-showline / sl-e-stripe-10: d-light / attributes-correctness
  • ✔️ philips-showline/sl-e-stripe-10-16 Bit - 10 Pixel.xml
✔️ philips-showline / sl-e-stripe-10: dmxcontrol3 / channel-numbers
  • ✔️ philips-showline-sl-e-stripe-10-16-Bit---10-Pixel.xml
philips-showline / sl-e-stripe-10: dragonframe / json-schema-conformity
  • ❌ philips-showline/sl-e-stripe-10.jsonfixture/matrix/pixelCount/0 null must be integer
  • ✔️ manufacturers.json
philips-showline / sl-e-stripe-10: millumin / json-schema-conformity
  • ❌ philips-showline/sl-e-stripe-10.jsonfixture/matrix/pixelCount/0 null must be integer
philips-showline / sl-e-stripe-10: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Philips-Showline-SL-e-Stripe-10-.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected ./manufacturer/fixture.qxf: Invalid power consumption 1 definitions processed. 2 errors detected
philips-showline / sl-e-stripe-10: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Philips-Showline-SL-e-Stripe-10-.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Layout', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant