Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture beamz/moveing-head-1 #3941

Closed
wants to merge 1 commit into from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture beamz/moveing-head-1

Fixture warnings / errors

  • beamz/moveing-head-1
    • ❌ File does not match schema: fixture/wheels/Color Wheel/slots must NOT have fewer than 2 items

Thank you @Luispupuis!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

beamz / moveing-head-1: d-light / attributes-correctness
  • ❌ beamz/moveing-head-1-MAIN.xmlError parsing XML: Duplicate parameter name: FOCUS/TILT,Duplicate parameter name: FOCUS/TILT
✔️ beamz / moveing-head-1: dmxcontrol3 / channel-numbers
  • ✔️ beamz-moveing-head-1-MAIN.xml
beamz / moveing-head-1: dragonframe / json-schema-conformity
  • ❌ beamz/moveing-head-1.jsonfixture/wheels/Color Wheel/slots must NOT have fewer than 2 items
  • ✔️ manufacturers.json
✔️ beamz / moveing-head-1: millumin / json-schema-conformity
  • ✔️ beamz/moveing-head-1.json
beamz / moveing-head-1: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/BeamZ-Moveing-head-1.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
beamz / moveing-head-1: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/BeamZ-Moveing-head-1.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

@Luispupuis
Copy link

I named it wrong :/

@luc122c
Copy link
Contributor

luc122c commented May 3, 2024

I named it wrong :/

The fixture also seems to be missing some crucial information such as a manual. Please see here for the infomation used to review fixture contributions.

I'll close this PR, please feel free to upload a more complete definition, or open a PR to amend this one. Thanks!

@luc122c luc122c closed this May 3, 2024
@luc122c luc122c added the incomplete Only partly implemented, needs considerate amount of work to finish/improve. label May 3, 2024
@luc122c luc122c deleted the branch2024-05-02T13-42-35 branch May 3, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incomplete Only partly implemented, needs considerate amount of work to finish/improve. new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants