New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fixture 'powerlighting/wash-84w' #461
Conversation
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. Fixture
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FloEdelmann Please review as well.
@ameisso or @anome: I've did some changes, are they okay?
Is there a manual (PDF or website) available anywhere? |
Broken links(Output of test script There were 0 internal and 6 external links failing.
|
Hey. Philippe speaking. Anyway, it's good. To make the fixture easier to use, the capabilities for "Pan", "Tilt" and "Speed" could be removed (they are useless at the end). But I don't have the right to perform a commit on this PR. I attached the final JSON file in case you could make it. Else, I'll send a PR after the merge. Best. Philippe |
Hey @anome! We're currently migrating our fixtures in #425 to the new capability syntax (see also #478). If you're interested, you can have a look at the diff for the Powerlighting Wash 84W you added in this PR. It would be nice if you could tell us if everything looks good, especially for the |
Hi. Looks fine to me. We gonna add some units in our interface anytime soon ! |
Thank you Anonymous!