Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fixture 'powerlighting/wash-84w' #461

Merged
merged 8 commits into from Apr 5, 2018
Merged

Conversation

FloEdelmann
Copy link
Member

  • update manufacturers.json
  • add fixture 'powerlighting/wash-84w'
  • update register.json

Thank you Anonymous!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Mar 30, 2018
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-461 March 30, 2018 10:21 Inactive
@FloEdelmann
Copy link
Member Author

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

Fixture powerlighting/wash-84w changed in this PR

  • d-light
    • attributes-correctness
      • ✅ powerlighting/wash-84w-default.xml
  • ecue
  • ofl
  • qlcplus
    • xsd-schema-conformity
      • ✅ Power-Lighting-Wash-84W.qxf

@fxedel fxedel self-assigned this Apr 2, 2018
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-461 April 2, 2018 11:22 Inactive
Copy link
Member

@fxedel fxedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FloEdelmann Please review as well.

@ameisso or @anome: I've did some changes, are they okay?

@FloEdelmann
Copy link
Member Author

Is there a manual (PDF or website) available anywhere?

@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-461 April 4, 2018 19:56 Inactive
@anome
Copy link
Contributor

anome commented Apr 5, 2018

Hey. Philippe speaking.
Unfortenatly, there is no manual online, and we didn't find the manufacturer website. I guess they are just reselling rebranded devices.

Anyway, it's good. To make the fixture easier to use, the capabilities for "Pan", "Tilt" and "Speed" could be removed (they are useless at the end). But I don't have the right to perform a commit on this PR. I attached the final JSON file in case you could make it. Else, I'll send a PR after the merge.

Best. Philippe

wash-84w.json.txt

@FloEdelmann FloEdelmann merged commit 7ccfa22 into master Apr 5, 2018
@FloEdelmann FloEdelmann deleted the branch2018-03-30T10-20-42 branch April 5, 2018 11:14
@FloEdelmann
Copy link
Member Author

Hey @anome!

We're currently migrating our fixtures in #425 to the new capability syntax (see also #478). If you're interested, you can have a look at the diff for the Powerlighting Wash 84W you added in this PR.

It would be nice if you could tell us if everything looks good, especially for the Strobe and RGBW preset channels. Thanks a lot!

@anome
Copy link
Contributor

anome commented Apr 18, 2018

Hi. Looks fine to me. We gonna add some units in our interface anytime soon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants