Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change FindNumPy.cmake for FindNumpy.cmake #61

Closed
marnunez opened this issue Jan 25, 2017 · 6 comments
Closed

change FindNumPy.cmake for FindNumpy.cmake #61

marnunez opened this issue Jan 25, 2017 · 6 comments
Assignees
Milestone

Comments

@marnunez
Copy link
Contributor

No description provided.

@Alzathar
Copy link
Member

Can you detail this issue? Is it a CMake detection problem? Or the usage of the associated macro in the CMake scripts?

@marnunez
Copy link
Contributor Author

marnunez commented Jan 25, 2017 via email

@marnunez
Copy link
Contributor Author

marnunez commented Jan 25, 2017

cmake 3.7.1
Linux 4.8.0-2-amd64 #1 SMP Debian 4.8.15-2 (2017-01-04) x86_64 GNU/Linux

Changing the file name works for me, everything compiles and tests are fine.

@Alzathar
Copy link
Member

Can you test on your side the modification of the line openma/cmake/OpenMALanguageBindings.cmake:71.

Instead of FIND_PACKAGE(Numpy REQUIRED) it should be FIND_PACKAGE(NumPy REQUIRED). You might need to clear the CMake cache to see the effect of this modification.

@marnunez
Copy link
Contributor Author

There, it works. As previously, all tests run successfully except #57: openma_io_handlerplugin_reader_bsf , but I know you're working on it.

@Alzathar
Copy link
Member

Thanks for feedback, I will modify the code ASAP.

Regarding the unit test openma_io_handlerplugin_reader_bsf, you should update your openma-data repository. I pushed the missing file yesterday night (see OpenMA/openma-data@9d783f7).

@Alzathar Alzathar self-assigned this Jan 26, 2017
@Alzathar Alzathar added this to the 1.0 milestone Jan 26, 2017
@Alzathar Alzathar modified the milestones: 1.0, 0.3 Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants