Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding external subsystem update #15

Merged
merged 9 commits into from
Jan 2, 2024

Conversation

xjjiang
Copy link
Contributor

@xjjiang xjjiang commented Dec 26, 2023

Summary

  • Finished writing the OAS example in onboarding_ext_subsystem.ipynb. Have to use run_model instead of run_driver because OAS runtime exceeded the maximum allowed.
  • In methods_for_level2.py, the variable final_range_nmi is commented out because it is never used and will cause error when run_model.
  • In onboarding_level2.ipynb, replaced bench2_history.db by aviary_history.db.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

Copy link
Contributor

@jkirk5 jkirk5 Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment for line 7 of the first codeblock (max_iter=1)?
# Max iterations set to 1 to reduce runtime of example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@johnjasa johnjasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made minor changes directly

@johnjasa johnjasa merged commit 7013de5 into OpenMDAO:main Jan 2, 2024
4 checks passed
@xjjiang xjjiang deleted the onboarding_ext_oas branch January 3, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants