POEM 071: Change ExecComp to use declare_coloring
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfalck
changed the title
declare_coloringdeclare_coloring
robfalck
changed the title
declare_coloringdeclare_coloring
Kenneth-T-Moore
approved these changes
Dec 19, 2022
naylor-b
reviewed
Dec 19, 2022
POEM_071.md
Outdated
| The option `has_diag_partials` on ExecComp was added prior to the development of partial derivative coloring to provide a common sparsity pattern for vectorized components. | ||
|
|
||
| With the advent of partial coloring, `has_diag_partials` is no longer needed. | ||
| Users should be able to expect that `ExecComp` will determine the sparsity pattern of calualtions involved. |
POEM_071.md
Outdated
|
|
||
| ## Changes | ||
|
|
||
| 1. `has_diag_partials` will be marked as deprecated but still be allowed as an option that does nothing. |
There was a problem hiding this comment.
We ended up leaving the old internal CS stuff intact because that allows us to use CS local to the ExecComp without requiring the full model vectors to be allocated as complex, and has_diag_partials offers a performance improvement over computing the coloring so I left it in (with no deprecation).
POEM_071.md
Outdated
| ## Changes | ||
|
|
||
| 1. `has_diag_partials` will be marked as deprecated but still be allowed as an option that does nothing. | ||
| 2. `declare_coloring_kwargs` will allow the user to specify any arguments to be passed to [System.declare_coloring](https://openmdao.org/newdocs/versions/latest/features/experimental/approx_coloring.html#dynamic-coloring)) |
There was a problem hiding this comment.
declare_coloring_kwargs wasn't used. The thought process was that if a user has specific args they need to pass (usually not the case), then they can just call declare_coloring and pass them normally. Otherwise, if they don't call declare_coloring explicitly, they get the internal coloring method that only uses default args.
Updated POEM 071 with implementation details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.