Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_problem now adds a recorder if not already present #437

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

robfalck
Copy link
Contributor

@robfalck robfalck commented Oct 30, 2020

Summary

The dymos.run_problem convenience function now attaches a problem recorder that saves to 'dymos_solution.db' if not already present. The recorder in the command line interface saves to the same one. Unfortunately, the way the CLI currently works, we couldn't just only add the recorder in run_problem, due to the way the hooks work.

Related Issues

Status

  • Ready for merge

Backwards incompatibilities

Trajectory.simulate now uses a Problem recorder to save the final results of the simulation.
This means that the results of the simulation are now obtained using

sim = om.CaseReader('dymos_simulation.db').get_case('final')

instead of

sim = om.CaseReader('dymos_simulation.db').get_case(-1)

New Dependencies

None

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 96.048% when pulling 3022937 on robfalck:run_problem_update2 into 38d7e36 on OpenMDAO:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 96.048% when pulling 3022937 on robfalck:run_problem_update2 into 38d7e36 on OpenMDAO:master.

@robfalck robfalck changed the title switching examples over to use tempdirs run_problem now adds a recorder if not already present Oct 31, 2020
@robfalck robfalck merged commit 70fe3a8 into OpenMDAO:master Nov 5, 2020
@robfalck robfalck deleted the run_problem_update2 branch December 17, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dymos run_problem function should automatically save a recording of the solution.
3 participants