Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making run_directory API forward compatible with new OpenMDAO changes #171

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Making run_directory API forward compatible with new OpenMDAO changes #171

merged 1 commit into from
Mar 1, 2024

Conversation

timryanb
Copy link
Collaborator

@timryanb timryanb commented Feb 20, 2024 •
edited
Loading

  • The current approach in the Scenario class for switching run directories before calling _apply_linear, _solve_linear, etc. methods is set to break when OpenMDAO/OpenMDAO #3113 is merged in due to a change in the call signature for these methods (see here)
  • I've re-factored the approach to be agnostic to the openmdao call signature for these methods using the python wraps decorator
  • These changes should be both backward- and forward-compatible with current and future OpenMDAO versions

@timryanb timryanb marked this pull request as draft February 20, 2024 16:30
@timryanb timryanb marked this pull request as ready for review February 27, 2024 20:04
@kejacobson kejacobson merged commit b4e4634 into OpenMDAO:main Mar 1, 2024
1 check passed
@timryanb timryanb deleted the run_dir_update branch March 4, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kejacobson kejacobson kejacobson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timryanb @kejacobson