Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the aerostructural optimization with DAFoam and TACS #79

Merged
merged 11 commits into from
Jan 21, 2022

Conversation

friedenhe
Copy link
Collaborator

No description provided.

friedenhe and others added 11 commits November 17, 2021 19:51
* Added the mphys iterface for fsi.

* Removed a deprecated option in DAFoam.

* Fixed the naming issue.

* Updated the warper to actually deform the mesh in the C++ layer.

* Added the mphys iterface for fsi.

* Removed a deprecated option in DAFoam.

* Fixed the naming issue.

* Updated the warper to actually deform the mesh in the C++ layer.

* Fixed a bug for DAFoamForce.
self.connect("mesh_struct.x_struct0", "geometry.x_struct_in")

def configure(self):
super().configure()
Copy link
Collaborator

@bernardopacini bernardopacini Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kejacobson This is the call I was referring to. On lines 207 and 208 we can define the rtol and atol values, but they do not actually take affect without calling super().configure() in the configure step. I just want to double check this is the expected behavior for an aerostructural case.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Yes, the multipoint configure method is where the solvers are set into the coupling groups. This has to be done in configure because the order of setup steps from the model's top level to the bottom is such that a default solver defined in aerostructural coupling group's setup would override the user's choice. My personal preference is that in the driver script not implement the configure method because it's a more advanced concept for OM users to understand what goes into setup vs configure. But I see why that's tricky with the need for the surface mesh connectivity from the aero solver to the geometry.

Copy link
Collaborator

@kejacobson kejacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to merge to me.

@kejacobson kejacobson merged commit 61948c5 into main Jan 21, 2022
@kejacobson kejacobson deleted the dafoam_aero_struct branch February 7, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants