Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a few more constraints to mphys_dvgeo #83

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Added a few more constraints to mphys_dvgeo #83

merged 4 commits into from
Feb 7, 2022

Conversation

friedenhe
Copy link
Collaborator

  • Added the pointSelect option to nom_addGeoDVLocal to allow selecting only part of the FFD points
  • Added the LERadius, Curvature, and LinearShape constraints

@anilyil
Copy link
Collaborator

anilyil commented Jan 29, 2022

Hi @friedenhe. The changes look good, but we dont test for these. We can merge this if it is working for your script. We should add tests for these when we move these wrapper to the pygeo repo

@friedenhe
Copy link
Collaborator Author

@anilyil . Sounds good. Thanks for checking. Yes, it worked for my run script.

@kejacobson kejacobson merged commit 9f1c18c into main Feb 7, 2022
@kejacobson kejacobson deleted the more_pygeo_constraints branch February 7, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilyil anilyil Awaiting requested review from anilyil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@friedenhe @anilyil @kejacobson