Updates to DAFoam components #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upName for getSurfaceCoordinates calls.
…oint optimizations.
|
I think the tests ran as needed, but let me know if I should make this from the main repository instead of a fork. |
|
Closing this PR as the fork has mysteriously disappeared. I will make a new PR instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all of the DAFoam components in MPHYS to the latest versions. Specifically, it makes multipoint cases possible, updates the tests / examples to the latest MPHYS updates, and has a few additional convenience updates as well.
The updates to the test scripts will conflict with the recent changes @kejacobson made to the DAFoam run scripts in PR #87, so I expect we will have merge conflicts there. The updates in this PR should be considered as the most up to date versions.