Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in dark mode #230

Merged
merged 5 commits into from
May 7, 2024
Merged

Fix link in dark mode #230

merged 5 commits into from
May 7, 2024

Conversation

cbielow
Copy link
Contributor

@cbielow cbielow commented May 6, 2024

User description

Describe the change

Fix a link in dark mode

PR checklist


PR Type

enhancement


Description

  • Corrected the navigation link for TOPPAS in the dark mode documentation to ensure it directs users to the appropriate starting guide.

Changes walkthrough 📝

Relevant files
Enhancement
workflows.rst
Update Link for TOPPAS in Dark Mode Documentation               

docs/getting-started/workflows.rst

  • Updated the link for TOPPAS in the dark mode section to point to the
    correct 'getting-started' page.
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @codiumai-pr-agent-pro codiumai-pr-agent-pro bot added the enhancement New feature or request label May 6, 2024
    Copy link
    Contributor

    PR Description updated to latest commit (e1fefc0)

    Copy link
    Contributor

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    1, because the PR involves a simple one-line change in a documentation file, which is straightforward to review.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    No

    🔒 Security concerns

    No

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestions                                                                                                                                                       
    Enhancement
    Adjust the link to be optimized for dark mode viewing.

    Ensure that the link provided in the :link: directive is consistent with the theme mode.
    Since the :class-card: is set to only-dark, it might be beneficial to provide a link that
    is optimized or specifically styled for dark mode viewing, if available.

    docs/getting-started/workflows.rst [96-98]

    -:link: /getting-started/toppas-get-started
    +:link: /getting-started/toppas-get-started-dark  # Assuming a dark mode optimized link exists
     :class-card: only-dark
     

    @cbielow cbielow requested a review from matteopilz May 6, 2024 14:09
    Copy link
    Collaborator

    @matteopilz matteopilz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Good catch, I have also found:

    :link: /getting-started/webapps

    @cbielow
    Copy link
    Contributor Author

    cbielow commented May 6, 2024

    fixed.
    ready for merge

    @matteopilz matteopilz merged commit 0503d8e into OpenMS:develop May 7, 2024
    1 check failed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants