Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code arrangement changes #9 #5486

Merged
merged 7 commits into from
Sep 1, 2021
Merged

Conversation

Arraxx
Copy link
Contributor

@Arraxx Arraxx commented Aug 9, 2021

Description

code arrangement changes for better readability.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

src/openms/source/FORMAT/QcMLFile.cpp Show resolved Hide resolved
src/openms/source/FORMAT/QcMLFile.cpp Outdated Show resolved Hide resolved
src/openms/source/FORMAT/QcMLFile.cpp Outdated Show resolved Hide resolved
src/openms/source/IONMOBILITY/IMDataConverter.cpp Outdated Show resolved Hide resolved
src/openms/source/IONMOBILITY/IMDataConverter.cpp Outdated Show resolved Hide resolved
src/openms/source/KERNEL/ConsensusFeature.cpp Outdated Show resolved Hide resolved
@Arraxx Arraxx changed the title code arrange changes #9 code arrangement changes #9 Aug 9, 2021
@timosachsenberg
Copy link
Contributor

rebuild jenkins

@Arraxx
Copy link
Contributor Author

Arraxx commented Aug 27, 2021

Ready for review @timosachsenberg

@timosachsenberg
Copy link
Contributor

rebuild jenkins

@timosachsenberg timosachsenberg merged commit 69aa1ca into OpenMS:develop Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants