Escape product names and translations inside js

[Judx]

Description (*)

Product names and translations are not escaped before being echoed into a JavaScript block.
If the product name and/or translation would include a double quote (") that would break the JavaScript.

Related Pull Requests

#2366

Manual testing scenarios (*)

i.e. JavaScript breaks when MAP with TIER-prices enabled

1. Create a new product with a a double quote " in the name
2. Enable MAP and "Show On Gesture"
3. Add MSRP, TIER and GROUP prices for the product
4. Go to the product page and try to "Click for price" -> Does not work as the JavaScript is broken

Catalog.Map.addHelpLink(
                    $('msrp-popup-1RFQl4noKSgLqDjmRse6K'),
                    "myproduct"",
...

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[elidrissidev]

LGTM. Can you please setup your git credentials and amend the commits.

[Judx]

I signed the commits and they are now verified with my key.

[sreichel]

LGTM, but i can't reproduce. I have no JS error in console.

[fballiano]

I've rebased it and fixed conflicts, it worked fine :-)

[fballiano]

the force push for the rebase dismissed @elidrissidev review sadly