Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md #2897

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Updated README.md #2897

merged 2 commits into from
Jan 5, 2023

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 5, 2023

Description (*)

Some minor changes.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

- IMHO highly valuable members taking time for reviews and make additions.
- would like to add luigifab too, but not w/o name (IMHO) :/
@sreichel
Copy link
Contributor Author

sreichel commented Jan 5, 2023

@ADDISON74 @luigifab missed to add you too, Am i allowed to add your full name?

@ADDISON74
Copy link
Contributor

In my case I am not a maintainer who has responsabilities. The actual role is just fine.

@sreichel
Copy link
Contributor Author

sreichel commented Jan 5, 2023

You are also responsible with every review or comment you do 😛

@elidrissidev
Copy link
Member

Thanks :)

@fballiano fballiano merged commit 3bcc383 into 1.9.4.x Jan 5, 2023
@fballiano fballiano deleted the readme branch January 5, 2023 08:36
fballiano pushed a commit that referenced this pull request Jan 5, 2023
@fballiano
Copy link
Contributor

directly merged this to 20.0 too since there were no conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants