Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated calls to strlen(), ref #2586 #2898

Merged
merged 2 commits into from
Jan 8, 2023
Merged

Updated calls to strlen(), ref #2586 #2898

merged 2 commits into from
Jan 8, 2023

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 5, 2023 •
edited
Loading

Description (*)

Fixes passing null to strlen().

Related Pull Requests

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel sreichel added the PHP 8.1 Related to PHP 8.1 label Jan 5, 2023
@github-actions github-actions bot added the Component: SalesRule Relates to Mage_SalesRule label Jan 5, 2023
kiatng
kiatng previously approved these changes Jan 5, 2023
View reviewed changes
Sdfendor
Sdfendor previously approved these changes Jan 5, 2023
View reviewed changes
@kiatng kiatng self-requested a review January 5, 2023 10:03
@sreichel sreichel marked this pull request as draft January 5, 2023 19:04
@sreichel sreichel dismissed stale reviews from Sdfendor and kiatng via 5650cdd January 5, 2023 19:51
@sreichel sreichel marked this pull request as ready for review January 5, 2023 19:53
@Flyingmana Flyingmana merged commit d676a47 into OpenMage:1.9.4.x Jan 8, 2023
fballiano pushed a commit to fballiano/openmage that referenced this pull request Jan 8, 2023
@sreichel @fballiano
Updated calls to strlen(), ref OpenMage#2586 (OpenMage#2898)
bb35b4a 
* Updated calls to strlen(), ref OpenMage#2586

* Update/fix
@fballiano
Copy link
Contributor

cherry picked this to 20.0 since there were no conflicts

sreichel added a commit to elidrissidev/magento-lts that referenced this pull request Jan 10, 2023
@sreichel
Update app/code/core/Mage/Newsletter/Model/Template.php
fd9ccc1 
See OpenMage#2898
kiatng pushed a commit to kiatng/magento-lts that referenced this pull request May 14, 2023
@sreichel @kiatng
Updated calls to strlen(), ref OpenMage#2586 (OpenMage#2898)
7616fbb 
* Updated calls to strlen(), ref OpenMage#2586

* Update/fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmotyl tmotyl tmotyl left review comments

@fballiano fballiano fballiano left review comments

@Sdfendor Sdfendor Sdfendor left review comments

@Flyingmana Flyingmana Flyingmana approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
Component: SalesRule Relates to Mage_SalesRule PHP 8.1 Related to PHP 8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sreichel @fballiano @Flyingmana @tmotyl @kiatng @Sdfendor