Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed session renew timestamp should be updated when customer changes password #2916

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Fixed session renew timestamp should be updated when customer changes password #2916

merged 1 commit into from
Apr 13, 2023

Conversation

colinmollenhour
Copy link
Member

Description (*)

In #2826 it was pointed out that a session key that was not using the proper constant seems to be left over from a previous commit (447e27e) which fixed a different issue but made that session key moot.

Related Pull Requests

#2212
#546

Fixed Issues (if relevant)

#2826

Manual testing scenarios (*)

Create customer and set password during checkout

Questions or comments

Needs testing...

@colinmollenhour colinmollenhour force-pushed the unused-validator-session-expire-timestamp-2826 branch from 57959d7 to d6334fe Compare January 9, 2023 20:51
@github-actions github-actions bot added Component: AdminNotification Relates to Mage_AdminNotification Component: Adminhtml Relates to Mage_Adminhtml Component: Admin Relates to Mage_Admin Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Cm/RedisSession Relates to Cm_RedisSession Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Contacts Relates to Mage_Contacts Component: Core Relates to Mage_Core Component: Cron Relates to Mage_Cron Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory ddev documentation environment labels Jan 9, 2023
@github-actions github-actions bot added phpunit ddev and removed Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Checkout Relates to Mage_Checkout labels Apr 4, 2023
@colinmollenhour colinmollenhour added the Rebased: RFC-0002 This PR has been rebased onto either 'main' or 'next' according to RFC-0002 label Apr 4, 2023
@elidrissidev elidrissidev added Component: Core Relates to Mage_Core Component: Checkout Relates to Mage_Checkout Component: Customer Relates to Mage_Customer and removed documentation environment Component: AdminNotification Relates to Mage_AdminNotification Component: Adminhtml Relates to Mage_Adminhtml Mage.php Relates to app/Mage.php Component: Admin Relates to Mage_Admin Component: Cm/RedisSession Relates to Cm_RedisSession htaccess phpstan phpcs php-cs-fixer PHPStorm phpunit ddev labels Apr 4, 2023
luigifab
luigifab approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@luigifab luigifab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

@fballiano fballiano changed the title Fix session renew timestamp should be updated when customer changes password. Fixes #2826 Fixed session renew timestamp should be updated when customer changes password Apr 13, 2023
fballiano
fballiano approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

briefly tested, seems to work fine

@fballiano fballiano merged commit e569375 into OpenMage:main Apr 13, 2023
fballiano pushed a commit that referenced this pull request Apr 13, 2023
@colinmollenhour @fballiano
Fixed session renew timestamp should be updated when customer changes…
7584c1c 
… password (#2916)
@fballiano
Copy link
Contributor

cherry picked on v19 too since it's a regression affecting that branch too

@kiatng kiatng mentioned this pull request Apr 16, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@luigifab luigifab luigifab approved these changes

@sreichel sreichel Awaiting requested review from sreichel

@ADDISON74 ADDISON74 Awaiting requested review from ADDISON74

@elidrissidev elidrissidev Awaiting requested review from elidrissidev

@Flyingmana Flyingmana Awaiting requested review from Flyingmana

@kiatng kiatng Awaiting requested review from kiatng

@tmotyl tmotyl Awaiting requested review from tmotyl

Assignees
No one assigned
Labels
Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Rebased: RFC-0002 This PR has been rebased onto either 'main' or 'next' according to RFC-0002
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused 'VALIDATOR_SESSION_EXPIRE_TIMESTAMP'
4 participants
@colinmollenhour @fballiano @luigifab @elidrissidev