Avoid session invalidation when changing session lifetime. #546
Conversation
colinmollenhour
requested review from
LeeSaferite,
Flyingmana,
drobinson,
tmotyl and
sreichel
|
The validation code uses |
colinmollenhour
force-pushed
the
session-validation-fixes
branch
from
370a6e7
to
17b744d
Compare
| if (strpos($currentCookieDomain, $host) > 0) { | ||
| $cookie->delete($this->getSessionName(), null, $host); | ||
| } | ||
| $secureCookieName = session_name() . '_cid'; |
There was a problem hiding this comment.
$sessionName is passed anyway, why switching to method?
There was a problem hiding this comment.
Because $sessionName can be null. I suppose it could be $this->getSessionName() but it would be functionally equivalent.
I added the constant back in. |
|
I merged the latest and cleaned up the logic around the secure cookie check to make it easier to read and understand without changing the functionality. These changes are good improvements IMO and no BC breakage. Please review! Thanks! |
sreichel
added
enhancement
Component: Core
|
@colinmollenhour could you address the conflicts here? I was checkin them but I don't trust my knowledge of this specific subject. |
|
I resolved the conflicts. |
|
phpstan doesn't let anything slip :-D |
…penMage#546)" This reverts commit 447e27e.
This PR fixes a few session related issues:
Varien_Date::toTimestampsession_before_renew_cookieevent to allow session lifetime to be more dynamic (e.g. I use this event to make sessions for customers with items in their cart much longer than those without).