Replies: 4 comments 22 replies
-
|
I tested to I also don't understand this new file After I checked (only) Not sure why. |
Beta Was this translation helpful? Give feedback.
-
|
answering just to a small part, https://github.com/OpenMage/magento-lts#since-openmage-1950--2010 you can find a command to remove ib/Credis lib/Pelago lib/Zend lib/phpseclib lib/mcryptcompat, composer won't remove those. |
Beta Was this translation helpful? Give feedback.
-
|
oh yeah! I didn't read the readme, only the changelog here! |
Beta Was this translation helpful? Give feedback.
-
|
ye I should have mentioned it but it's not easy to keep track of everything |
Beta Was this translation helpful? Give feedback.
-
|
Today I tested
We are almost there! |
Beta Was this translation helpful? Give feedback.
-
|
Can you post all these deprecations with the filename and line number? I'd like to tackle them and that'd help a lot. |
Beta Was this translation helpful? Give feedback.
-
|
Table.php, app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Table.php, line 84, An idea: @@ -80,6 +80,10 @@ class Mage_Eav_Model_Entity_Attribute_Source_Table extends Mage_Eav_Model_Entity
*/
public function getOptionText($value)
{
+ if ($value === null) {
+ return false;
+ }
+
$isMultiple = false;
if (strpos($value, ',')) {
$isMultiple = true;-- Source.php, app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Source.php, line 238, -- Abstract.php, app/code/core/Mage/Core/Model/Resource/Helper/Abstract.php, line 309, -- Abstract.php, app/code/core/Mage/Core/Model/Resource/Db/Abstract.php, line 666, -- Flat.php, app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php, line 670, |
Beta Was this translation helpful? Give feedback.
-
|
- if (strpos($value, ',')) {
+ if (is_string($value) && strpos($value, ',')) {or - if (strpos($value, ',')) {
+ if (strpos((string) $value, ',')) { |
Beta Was this translation helpful? Give feedback.
-
|
I found the following incompatible change in Before we can: Sentry report: Before we can: Sentry report: |
Beta Was this translation helpful? Give feedback.
-
|
I suppose this come from OpenMage, but I haven't searched. |
Beta Was this translation helpful? Give feedback.
-
|
For the second issue, it's a security change that was added to zf1-future, it was already discussed in the PR |
Beta Was this translation helpful? Give feedback.
-
|
Which PR? I didn't see it, or I forgot it. |
Beta Was this translation helpful? Give feedback.
-
|
I forgot you were not part of the reviewers. It was discussed in #2861. |
Beta Was this translation helpful? Give feedback.
-
|
Okay, so there is no problem. |
Beta Was this translation helpful? Give feedback.
-
|
There are also two new bugs: With #2902, each time I save a category without any changes, I have: I fixed with (but not sure if it's good or not): --- a/web/lib/Varien/File/Uploader.php
+++ b/web/lib/Varien/File/Uploader.php
@@ -161,10 +161,10 @@ class Varien_File_Uploader
$this->_setUploadFileId($fileId);
if (empty($this->_file['tmp_name']) || !file_exists($this->_file['tmp_name'])) {
$errorCode = $this->_file['error'] ?? 0;
+ $code = empty($this->_file['tmp_name']) ? self::TMP_NAME_EMPTY : 0;
if ($errorCode && isset(self::UPLOAD_ERRORS[$errorCode])) {
- throw new Exception(self::UPLOAD_ERRORS[$errorCode]);
+ throw new Exception(self::UPLOAD_ERRORS[$errorCode], $code);
}
- $code = empty($this->_file['tmp_name']) ? self::TMP_NAME_EMPTY : 0;
throw new Exception('File was not uploaded.', $code);
} else {
$this->_fileExists = true;With #2939, I have tons of: I removed the |
Beta Was this translation helpful? Give feedback.
-
|
It is not right at all that when you save a category without making any changes, to get that error message. I will check if I can reproduce this issue. In #2902 I don't see any changes that generate this issue, only all the errors that can occur related to loading images are logged. |
Beta Was this translation helpful? Give feedback.
-
|
:'( I'm sad, the stack trace is only in app/code/core for the error when I save a category... I will check again later. |
Beta Was this translation helpful? Give feedback.
-
|
The error is still here for me with commit 1e8fcd0 - 19.5.0-rc2 (fresh git) in exception.log. |
Beta Was this translation helpful? Give feedback.
-
|
@luigifab Yeah I'm able to see the exception running the rc2 release, I thought the exception shows up in the admin but it only logs it. I will investigate. Full log |
Beta Was this translation helpful? Give feedback.
-
|
This is now fixed with #3086. |
Beta Was this translation helpful? Give feedback.
-
Highlights
This is a big release, that's why we decided to move away from the 19.4.x versioning and go to 19.5.x. Since a lot of changes could have some impact on current installations we decided to release some "rc" versions before the official 19.5.0. Tests are more than welcome now but be extra careful with production environment.
What's most important is the removal of all the 3rd party libraries (phpseclib, mcrypt_compat, Cm_RedisSession, Cm_Cache_Backend_Redis and Pelago_Emogrifier and Zend Framework) form our repository, they are now imported via composer. This was an important step to clean up and modernise our code.
Also the M1 legacy themes have been moved to an external repository since it's old (and mostly unused) code.
Don't worry though, if you've always installed OpenMage extracting the zip file, starting from this release you'll find a new zip file attached to the release itself, we build this zip adding all of the old 3rd party libraries so that you will not have to migrate to composer or use composer at all.
Changelog
New Contributors
Full Changelog: v19.4.20...v19.5.0-rc1
This discussion was created from the release v19.5.0-rc1.
Beta Was this translation helpful? Give feedback.
All reactions