Fixed $address is null in AddressController.

[kiatng]

Description (*)

I have this error log in a production instance:

Array
(
    [type] => 1:E_ERROR
    [message] => Uncaught Error: Call to a member function getId() on null in /app/code/core/Mage/Customer/controllers/AddressController.php:163
  thrown
    [file] => /app/code/core/Mage/Customer/controllers/AddressController.php
    [line] => 163
    [uri] => /customer/address/formPost/?form_key=llZ2YRTc7teqJ5qD&success_url=&error_url=&firstname=JEMS&middlename=STEV&lastname=LEO&company=%5C&telephone=%27&fax=%27&street%5B%5D=%27&street%5B%5D=%27&city=%27®ion_id=®ion=&postcode=*&country_id=AU&default_billing=1&default_shipping=1
)

Looking at the uri, it seems it's an attempt by some bad agent trying something. It needs to extract the form_key and test the server to reveal something.

This is because when line 99 $this->getRequest()->isPost() is false, $address is not defined:

magento-lts/app/code/core/Mage/Customer/controllers/AddressController.php

Lines 93 to 102 in d8bd81b

	public function formPostAction()
	{
	if (!$this->_validateFormKey()) {
	return $this->_redirect('*/*/');
	}
	// Save data
	if ($this->getRequest()->isPost()) {
	$customer = $this->_getSession()->getCustomer();
	/** @var Mage_Customer_Model_Address $address */
	$address = Mage::getModel('customer/address');

Manual Testing

You can extract the form key and then attach the URI to your domain in the browser:

/customer/address/formPost/?form_key={replace with your key}&success_url=&error_url=&firstname=JEMS&middlename=STEV&lastname=LEO&company=%5C&telephone=%27&fax=%27&street%5B%5D=%27&street%5B%5D=%27&city=%27®ion_id=®ion=&postcode=*&country_id=AU&default_billing=1&default_shipping=1
)

The output depends on your server config.