Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug on incorrect date format for 1970-01-01 date. #3802

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Fixed bug on incorrect date format for 1970-01-01 date. #3802

merged 1 commit into from
Feb 6, 2024

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Feb 6, 2024 •
edited
Loading

Description (*)

Test script:

$result = Mage::helper('core')->formatDate('1970-01-01');
// or Mage::helper('core')->formatDate('1 Jan 1970');
Zend_Debug::dump($result);

Before PR:

string(0) ""

After PR, depending on your locale default format:

 string(10) "01/01/1970"

Related Pull Requests

PR #1525

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Feb 6, 2024
@fballiano fballiano merged commit 444c4b0 into OpenMage:main Feb 6, 2024
17 checks passed
@kiatng kiatng deleted the 1970-01-01_bug branch February 7, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiatng @fballiano @ADDISON74