Removed obsolete CCSave payment method #3984
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Template : admin
|
PHPStan error will be solved by merging #3976 |
|
Perhaps it can be interesting to add a dummy payment method, and a SQL to clean and update db? |
boesbo
approved these changes
May 28, 2024
boesbo
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets
nextCCSave is an old payment method that saved the credit card data directly in the database, this is not used (and nobody should use it) anymore since years.
I've checked my customers' projects and I didn't see any module extending these classes. Although it's possible that there's something out there, it should be part of some functionality that's not in use anymore.
Note: this PR will break the possibility of viewing old orders payed with the ccsave method, as shown in #3441, my opinion is that having merchants still using ccsave in any way could be considered dangerous but probably they don't know (but I think they should and would prefer to know) so at least if the functionaly breaks on their website they will be able to understand that they were having a problematic situation, fix it and most importantly sanitize their database (you don't want to receive a security audit for them to discover you have credit cards stored in your database).