Fixed another bug where it was not possible to retrieve payment child transactions #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transactions. getType does not exist, getTxnType is the right magic function since the data key is txn_type
colinmollenhour
approved these changes
Jan 31, 2018
LeeSaferite
approved these changes
Jan 31, 2018
|
+1 merge? |
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 9, 2018
…t_Transaction::getChildTransactions() getType() does not exist, getTxnType() is the right magic function since the data key is txn_type
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 28, 2018
…t_Transaction::getChildTransactions() getType() does not exist, getTxnType() is the right magic function since the data key is txn_type
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Mar 20, 2018
…t_Transaction::getChildTransactions() getType() does not exist, getTxnType() is the right magic function since the data key is txn_type
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Jul 17, 2018
…t_Transaction::getChildTransactions() getType() does not exist, getTxnType() is the right magic function since the data key is txn_type
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Sep 19, 2018
…t_Transaction::getChildTransactions() getType() does not exist, getTxnType() is the right magic function since the data key is txn_type
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 14, 2019
…t_Transaction::getChildTransactions() getType() does not exist, getTxnType() is the right magic function since the data key is txn_type
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Apr 1, 2019
…t_Transaction::getChildTransactions() getType() does not exist, getTxnType() is the right magic function since the data key is txn_type
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
…t_Transaction::getChildTransactions() getType() does not exist, getTxnType() is the right magic function since the data key is txn_type
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
…t_Transaction::getChildTransactions() getType() does not exist, getTxnType() is the right magic function since the data key is txn_type
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
…t_Transaction::getChildTransactions() getType() does not exist, getTxnType() is the right magic function since the data key is txn_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it can be seen everywhere around this class, the correct way to get the transaction type is:
->getTxnType() no ->getType()
Without this fix, its not possible to retrieve child transaction of a transaction f.e getting the child VOID transaction of an AUTH transaction