Fix backend creationdate bug #465
Conversation
We dont want system time in backend. https://magento.stackexchange.com/questions/38143/customer-created-logged-in-timestamps-in-admin Discovered whilst testing for GDPR: when customer asks "when" did I subscribe our data is always 1 hour off
| @@ -78,8 +78,12 @@ public function getCustomerLog() | |||
| */ | |||
| public function getCreateDate() | |||
| { | |||
| return $this->_getCoreHelper()->formatDate($this->getCustomer()->getCreatedAt(), | |||
| Mage_Core_Model_Locale::FORMAT_TYPE_MEDIUM, true); | |||
| $date = Mage::app()->getLocale()->storeDate( | |||
There was a problem hiding this comment.
Indentation level is off on this whole block.
There was a problem hiding this comment.
Generally speaking I disagree with this PR since it's not fixing a bug but instead changing behavior to what you expect. This method is meant to return a date formatted for the currently selected timezone as it's stored in the DB (which should be UTC I would hope) . If you notice, the very next method is getStoreCreateDate() and it does exactly what you want. If you think admin should be displaying the store date then instead why not edit the template to use the correct method? Even better would be a new bool config path and then check that in the template to have both behaviors. You could leave the default as the old behavior and use the flag to change to using store times instead.
|
Agree. Config flag little too much. But yes.
|
|
Looks like the template already accounts for difference for timezone vs time But in our case the 2 are the same which is strange because it should not be (there is 1 hour offset)
|
|
See #466 |
We dont want system time in backend.
https://magento.stackexchange.com/questions/38143/customer-created-logged-in-timestamps-in-admin
Discovered whilst testing for GDPR: when customer asks "when" did I subscribe our data is always 1 hour off