-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 176 #317
Conversation
This is content only and hasn't been properly integrated with the system we are using. Would need someone to integrate the content and check the image links since they are relative to the main tree. |
@inomyabcs Thanks for starting this! I don't have time to get this integrated into the site right now, so I'll make an issue for it that someone might pick up. |
@rentry Can you please help with this? There's a new page that needed the styling of the site added to it. I added front matter to give it a template, but it's sizing weirdly and it broke all the icons that were in the page. |
@shannonmcharg This page will be difficult to integrate, since it has around 235 lines of inline CSS, some of which rewrite important styling for the layout of the website. For example, it imposes styling on the We would have to go through it line-by-line to remove some CSS, pull the in-line CSS for the step chart into the stylesheet, etc., but if we do that, it will still take some effort to make sure that it looks like it's intended to. I don't have time to do all of that for a while, but I can look into it some other time if I find a few hours. In the meantime, if you want to add it, I would recommend doing so as a bespoke page. With all that inline styling, it current assumes itself as an independent page. |
Deconflicts with archive.html template's h1 style
@rentry Thanks for taking a look! We'll table this page for later. |
Removed manual styles for animation of the ballotfill.html page to streamline integration and improve performance. Added separate sass template for moving the manual style out of the source page.
I have modified the ballot page using the USWDS page recommended by @rentry. The deploy preview shows that it isn't breaking the site layout. There are some little cosmetic changes that will need to be performed later (the blue line is off centered and the text sizing in each section needs adjusting). |
Nice @inomyabcs! I added a few tweaks via #331! It looks great, and retains 100% accessibility 👍 |
The preview on this one looks great! |
Styles left border, tweaks padding, removes border from last item
Is all that's left to do on this to add a link to the page from the How to Vote in Maine page? |
Looks like it. Everyone seems happy with the page. |
I added a link under the Vote by Mail section. @rentry I probably have the wrong verb construction, if you want to tweak it. |
I'll push up some heading tweaks in a bit. |
@inomyabcs It won't let me add you a reviewer, since it's your pull request. If everything looks good to you, feel free to merge. |
Thank you all for your assistance. |
Content about properly filling out an absentee ballot. Not integrated with main website.
This is an enhancement or feature.
Summary
Adds absentee ballot instructions and informs on common rejections of absentee ballots.
Context
Fulfills issue 176.