Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 176 #317

Merged
merged 14 commits into from
Sep 3, 2023
Merged

Issue 176 #317

merged 14 commits into from
Sep 3, 2023

Conversation

inomyabcs
Copy link
Member

Content about properly filling out an absentee ballot. Not integrated with main website.

This is an enhancement or feature.

Summary

Adds absentee ballot instructions and informs on common rejections of absentee ballots.

Context

Fulfills issue 176.

Content about properly filling out an absentee ballot. Not integrated with main website.
@inomyabcs inomyabcs linked an issue May 27, 2023 that may be closed by this pull request
@inomyabcs inomyabcs marked this pull request as ready for review May 27, 2023 23:36
@inomyabcs
Copy link
Member Author

This is content only and hasn't been properly integrated with the system we are using. Would need someone to integrate the content and check the image links since they are relative to the main tree.

@shannonmcharg
Copy link
Member

@inomyabcs Thanks for starting this! I don't have time to get this integrated into the site right now, so I'll make an issue for it that someone might pick up.
Page preview: https://deploy-preview-317--awesome-lamarr-6d076d.netlify.app/ballotfill.html

@shannonmcharg
Copy link
Member

@rentry Can you please help with this? There's a new page that needed the styling of the site added to it. I added front matter to give it a template, but it's sizing weirdly and it broke all the icons that were in the page.

@rentry
Copy link
Contributor

rentry commented Aug 30, 2023

@shannonmcharg This page will be difficult to integrate, since it has around 235 lines of inline CSS, some of which rewrite important styling for the layout of the website. For example, it imposes styling on the html, body, and headings, which (because of the specificity of being page-level) replace global styling on the page. It also rewrites mobile views and breakpoints. As-is, we won't be able to integrate it.

We would have to go through it line-by-line to remove some CSS, pull the in-line CSS for the step chart into the stylesheet, etc., but if we do that, it will still take some effort to make sure that it looks like it's intended to.

I don't have time to do all of that for a while, but I can look into it some other time if I find a few hours. In the meantime, if you want to add it, I would recommend doing so as a bespoke page. With all that inline styling, it current assumes itself as an independent page.

Deconflicts with archive.html template's h1 style
@shannonmcharg
Copy link
Member

@rentry Thanks for taking a look! We'll table this page for later.

Removed manual styles for animation of the ballotfill.html page to streamline integration and improve performance.  Added separate sass template for moving the manual style out of the source page.
@inomyabcs
Copy link
Member Author

I have modified the ballot page using the USWDS page recommended by @rentry. The deploy preview shows that it isn't breaking the site layout. There are some little cosmetic changes that will need to be performed later (the blue line is off centered and the text sizing in each section needs adjusting).

@rentry
Copy link
Contributor

rentry commented Sep 1, 2023

Nice @inomyabcs! I added a few tweaks via #331! It looks great, and retains 100% accessibility 👍

@shannonmcharg
Copy link
Member

The preview on this one looks great!

Styles left border, tweaks padding, removes border from last item
@shannonmcharg
Copy link
Member

Is all that's left to do on this to add a link to the page from the How to Vote in Maine page?

@inomyabcs
Copy link
Member Author

Looks like it. Everyone seems happy with the page.

@shannonmcharg
Copy link
Member

I added a link under the Vote by Mail section. @rentry I probably have the wrong verb construction, if you want to tweak it.

@rentry
Copy link
Contributor

rentry commented Sep 2, 2023

There is one more issue to look into with this one, which I should have caught and I'm surprised the accessibility checker didn't catch.

The page doesn't currently have an h1 or h2, skipping to h3 and h4s for the list items.

A headings map of the page with the h3 highlighted in red

Ideally, it would have an h1 page title, then proceed to h2 and so on.

@rentry
Copy link
Contributor

rentry commented Sep 2, 2023

I'll push up some heading tweaks in a bit.

@shannonmcharg
Copy link
Member

@inomyabcs It won't let me add you a reviewer, since it's your pull request. If everything looks good to you, feel free to merge.

@inomyabcs
Copy link
Member Author

Thank you all for your assistance.

@inomyabcs inomyabcs closed this Sep 3, 2023
@inomyabcs inomyabcs reopened this Sep 3, 2023
@inomyabcs inomyabcs merged commit 5bcb733 into master Sep 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write content about properly filling out an absentee ballot
3 participants