Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option for archiving local elections #95

Merged
merged 2 commits into from
May 10, 2020
Merged

Conversation

rentry
Copy link
Contributor

@rentry rentry commented May 10, 2020

This isn't ideal, but I thought I would send it up for review.

This branch adds the following:

  • Introduces new subfolder for local election csvs in data directory
  • New collection for local elections with a markdown file for each local election
    • Local election front matter points to the respective local election csv in _data directory
  • Creates _include for search input and table loop, in which the data file declaration references individual local election front matter

I'm not convinced this is the best approach, but it does have some advantages:

  • We can loop through the collection and output results in the archive
  • Allows for a crosswalk of metadata to csv data files

This method will require creating a new .md file in the collection with properly formatted front matter.

@rentry
Copy link
Contributor Author

rentry commented May 10, 2020

Example of local page is at path /local-archive/local-2019-11/

@inomyabcs
Copy link
Member

inomyabcs commented May 10, 2020

I think I prefer this approach. I would recommend adding the clear_local_ballot perl script to blank out the csv ballot column for each new election, unless there is a cleaner way to do it.

Copy link
Member

@shannonmcharg shannonmcharg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We just need to add a way to link to the archive local pages from the archive.

@rentry
Copy link
Contributor Author

rentry commented May 10, 2020

☝️ That commit adds a loop through local collection to add to archive page.

  • Could use page-level nav to jump to local
  • Relies on the election key in front matter

Copy link
Member

@inomyabcs inomyabcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@shannonmcharg shannonmcharg self-requested a review May 10, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants