Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scscp cdgroups file only picks up one comment #24

Closed
kohlhase opened this issue Sep 30, 2017 · 3 comments
Closed

scscp cdgroups file only picks up one comment #24

kohlhase opened this issue Sep 30, 2017 · 3 comments
Assignees
@davidcarlisle

Comments

@kohlhase
Copy link
Member

I added a comment to the SCSCP cdgroup file, but https://openmath.github.io/cdgroups/scscp only picks up one. I am not sure what I did wrong. please fix.
@kohlhase kohlhase mentioned this issue Sep 30, 2017
Open
davidcarlisle added a commit that referenced this issue Sep 30, 2017
@davidcarlisle
re-arrange comments for issue #24
924aa04
@davidcarlisle
Copy link
Member

the comment has to come before the cd entry not after. In an ideal world the comment would be inside the CDGroupMember entry but we'd already shipped openmath 2.0 (or 1.0?) only allowing comments at the outer level in cdgroup files, and with cdgroups with no such comments before I needed them to make a reasonable web index page, and so we went with adding them immediately before each entry.

@kohlhase
Copy link
Member Author

Ah, OK. If you reorder the file, I will make an issue for OM3 (we should really fix this if we change anything).

@kohlhase
Copy link
Member Author

OK, the issue is at OpenMath/OMSTD#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcarlisle davidcarlisle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidcarlisle @kohlhase