Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'TwoVarCompModelRotate' function need to be modified to output eigen vectors #1

Closed
jinjinzhou opened this issue Sep 1, 2016 · 2 comments

Comments

@jinjinzhou
Copy link
Contributor

When using LRT for GWAS, eigen vectors of (co)variance matrices needed to be stored under the null model so that we can rotate covariates including SNPs under all alternative models and to avoid to call 'TwoVarCompModelRotate' many times.

@Hua-Zhou
Copy link
Member

Hua-Zhou commented Sep 1, 2016

It makes sense. Please go ahead make the changes.

On Thu, Sep 1, 2016 at 4:19 PM, Jin Zhou notifications@github.com wrote:

When using LRT for GWAS, eigen vectors of (co)variance matrices needed to
be stored under the null model so that we can rotate covariates including
SNPs under all alternative models and to avoid to call
'TwoVarCompModelRotate' many times.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEwHsXc4QSsTCEbyPSM7bC-3Q4IqtbDQks5ql11kgaJpZM4JzOcc
.

@Hua-Zhou Hua-Zhou reopened this Sep 25, 2016
@Hua-Zhou
Copy link
Member

Fixed in fbfedc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants