Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chores/assorted upgrades #416

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Chores/assorted upgrades #416

merged 4 commits into from
Jun 2, 2022

Conversation

chinmayshah99
Copy link
Member

@chinmayshah99 chinmayshah99 commented Jun 2, 2022 •
edited
Loading

Description

  • Upgraded SHA
  • Fixed examples and added named parameters for the same.
  • added delta as an additional parameter when passing to c++ functions

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@chinmayshah99 chinmayshah99 added Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase algorithms related to anything in the algorithms directory (c++) dependencies Pull requests that update a dependency file labels Jun 2, 2022
@chinmayshah99 chinmayshah99 merged commit c004d87 into OpenMined:dev Jun 2, 2022
@chinmayshah99 chinmayshah99 deleted the chores/assorted-upgrades branch June 2, 2022 13:47
@chinmayshah99
Copy link
Member Author

Fixes #410, #412, #409.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
algorithms related to anything in the algorithms directory (c++) dependencies Pull requests that update a dependency file Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chinmayshah99