New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Padawan Trial 1: Uchechukwu Emmanuel] Add name to skill_test #7268

Merged

madhavajay merged 1 commit into OpenMined:padawan_trial_1 from onlyoneuche:uche/trial_1

Jan 30, 2023

Contributor

onlyoneuche commented Jan 29, 2023

Description

Added name in padawan trial 1.
Bumped isort to 5.12.0 based on this issue

Affected Dependencies

isort

How has this been tested?

Linting: pre-commit run --all-files
Tests Ran: tox -e padawan.trials

Checklist

I have followed the Contribution Guidelines and Code of Conduct
I have commented my code following the OpenMined Styleguide
I have labeled this PR with the relevant Type labels
My changes are covered by tests


          Added my name to padawans data in skill_test.py, bumped isort version…

6fc0b25

… to 5.12.0 because of dependency errors

madhavajay reviewed

View reviewed changes

.pre-commit-config.yaml

@@ @@ -55,7 +55,7 @@ repos: @@
                         )$
                 - repo: https://github.com/pycqa/isort
-                  rev: 5.10.1
+                  rev: 5.12.0

Collaborator

madhavajay Jan 30, 2023

👍 nice one.

madhavajay merged commit d5b9ae1 into OpenMined:padawan_trial_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet