speed up syft unit tests #8572
Merged
speed up syft unit tests #8572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eelcovdw
reviewed
Mar 14, 2024
| @@ -106,6 +108,7 @@ def salt_and_hash_password(password: str, rounds: int) -> tuple[str, str]: | |||
| return salt_bytes, hashed_bytes | |||
|
|
|||
|
|
|||
| @cache | |||
There was a problem hiding this comment.
Is the caching only to speed up CI? Not sure we want to do the caching with real passwords
There was a problem hiding this comment.
moved caching to conftest
yashgorana
reviewed
Mar 18, 2024
packages/syft/tests/conftest.py
Outdated
Comment on lines
212
to
216
| SyftClientSessionCache._get_key = ( | ||
| lambda email, password, connection: f"{email}{password}{connection}" | ||
| ) | ||
| user.salt_and_hash_password = cache(user.salt_and_hash_password) | ||
| user.check_pwd = cache(user.check_pwd) |
There was a problem hiding this comment.
This should be provisioned through monkeypatch.setattr in the fixture instead of making it a global patch?
There was a problem hiding this comment.
Good point! I applied the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I did some profiling on the unit tests and cleared up some bottlenecks.
There is roughly 35% speed up.
Local:
CI:
Affected Dependencies
Added orjson library for faster json processing.Hashing relies on the json file formatting and orjson is missing white spacing which is not configurable. So this change was reverted although there still some potential gains to be made.How has this been tested?
Checklist