Peers Managing API #8602
Merged
Peers Managing API #8602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
update their type annotations and docstrings
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- refactor `node_peer.py`
khoaguin
commented
Mar 26, 2024
fix bugs in network service's `add_route_for` and `delete_route_for`
…n node - exclude `notebooks/Experimental/*` for ruff in pre-commit
on the peer's node. - Refactoring `verify_peer`
both directions
- recheck if the connection to node peer uses the highest priority route
…ng a random route will give back a connection error
…is not specified
…rity` to `create_and_update_peer` Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
…otebook 10 to prevent flakiness - change role level of `delete_peer_by_id` back to `DATA_OWNER_ROLE_LEVEL` Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
shubham3121
requested changes
Apr 9, 2024
…rings - improve returned SyftError message if failed to create a remote client for a peer Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
instead of the whole NodePeer object Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
…ity` now takes peer's verify key instead of the whole NodePeer object Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
shubham3121
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Great work @khoaguin !!! 💯 🎉
These APIs would be really handy as an Admin and help in managing the Gateway. 🙏🏾
…ry components Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/OpenMined/Heartbeat/issues/1150
NodePeerworksNetworkService'sadd_route,verify_route)