Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused code paths from the CodeBase #8838

Merged
merged 19 commits into from
May 22, 2024

Conversation

rasswanth-s
Copy link
Collaborator

@rasswanth-s rasswanth-s commented May 21, 2024

Description

Resolves
https://github.com/OpenMined/Heartbeat/issues/1270

The PR removes

  • ansible
  • podman
  • packer
  • vagrant files
  • vm related test suites
  • Docker compose files
  • gevent

Note: There would be some documentation, that contains references to the same, which would be removed in a separate follow up PR.

Affected Dependencies

How has this been tested?

Existing Tests

Checklist

@rasswanth-s rasswanth-s changed the title Remove Unuse code paths from the CodeBase Remove Unused code paths from the CodeBase May 21, 2024
Copy link
Member

@shubham3121 shubham3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gevent w.r.t zmq changes looks good

from zmq import Frame
from zmq import LINGER
from zmq.error import ContextTerminated
import zmq.green as zmq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

Copy link
Collaborator

@madhavajay madhavajay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼 so fresh! Great work @rasswanth-s!

@rasswanth-s rasswanth-s merged commit 55036c8 into dev May 22, 2024
26 checks passed
@rasswanth-s rasswanth-s deleted the rasswanth/remove-unused-code branch May 22, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants