Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Hosting Revamp #9031

Merged
merged 12 commits into from
Jul 15, 2024
Merged

Conversation

rasswanth-s
Copy link
Collaborator

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@yashgorana yashgorana Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the "*.safetensors" from ignore_patterns? That way the whole notebook will be e2e runnable. currently this isn't running in CI so runtime shouldn't be an issue. but we should investigate why the asset are taking a lot of time to get ready as we discussed on slack.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run action object tests once locally before we merge this change - don't want stuff to break as this PR doesn't run the CI :)

Copy link
Collaborator Author

@rasswanth-s rasswanth-s Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran all the action object tests by tox -e syft.test.unit.
All the action objects passed ✅

There are a few tests ,which are failing for single domain user code, which are not related to this current PR , but due to the main PR.

@rasswanth-s rasswanth-s changed the title added execution context to Submit Code Model Hosting Revamp Jul 12, 2024
@itstauq itstauq merged commit c68df91 into tauquir/enclave-prototype Jul 15, 2024
3 of 4 checks passed
@itstauq itstauq deleted the rasswanth/model_hosting_v2 branch July 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants