-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model Hosting Revamp #9031
Model Hosting Revamp #9031
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
add ModelRef to upload dataset fixes model inference on eval dataset
modify submit_model to code_action_id
Add utility functions to wrap and unwrap initialized model Created a new notebook, for model-hosting + enclaves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the "*.safetensors" from ignore_patterns? That way the whole notebook will be e2e runnable. currently this isn't running in CI so runtime shouldn't be an issue. but we should investigate why the asset are taking a lot of time to get ready as we discussed on slack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run action object tests once locally before we merge this change - don't want stuff to break as this PR doesn't run the CI :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran all the action object tests by tox -e syft.test.unit.
All the action objects passed ✅
There are a few tests ,which are failing for single domain user code, which are not related to this current PR , but due to the main PR.
add client argument to save to blob storage
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist