Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model size calculation and improve repr #9133

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

itstauq
Copy link
Member

@itstauq itstauq commented Aug 4, 2024

Description

Closes OpenMined/Heartbeat#1680

  • The Size of Model is being calculated inaccurately
  • Round the Size to Two Decimal Places

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Fix repr of Model with MB
Update V3 noteboooks to show model coll repr
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rasswanth-s rasswanth-s changed the title [WIP] Fix model size calculation and improve repr Fix model size calculation and improve repr Aug 6, 2024
Copy link
Collaborator

@rasswanth-s rasswanth-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done @itstauq

@rasswanth-s rasswanth-s merged commit 714964f into tauquir/enclave-prototype Aug 6, 2024
3 of 4 checks passed
@rasswanth-s rasswanth-s deleted the tauquir/fix-model-size-repr branch August 6, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants