This repository has been archived by the owner on May 18, 2019. It is now read-only.
Handle # in the working path #2387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ticket:4896.
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2018-04-23_13-37-07. |
OpenModelica-Hudson
pushed a commit
that referenced
this pull request
Apr 23, 2018
Fixes ticket:4896. Belonging to [master]: - #2387
bernhard-thiele
pushed a commit
to bernhard-thiele/OMCompiler
that referenced
this pull request
May 8, 2018
23f84f5 Added ZeroMQ library 79cc72e Add 'libzmq/' from commit '10a9ba0926028a2e380a1409da278a48e5ecf3f8' 10a9ba0 Merge pull request #2593 from ilovexyz/dev af598f2 fix bug: dish client does not resend subscriptions to radio server after radio server restart 9980593 Merge pull request #2591 from laplaceyang/pr_cancel_timer_in_reconnect 67a6594 fix bug: coredump if set linger and immediate together bcc30f2 Merge pull request #2584 from GreatFruitOmsk/master 545135f RELICENSE: Ilya Kulakov ec56eaa Merge pull request #2583 from timou/wincmake 293a182 Suppress linker warning 4221 for MSVC 92339a4 Merge pull request #2582 from bluca/test_poller_use_after_free 1763753 Problem: use-after-free in test_poller bc8ad88 Merge pull request #2580 from diorcety/ninja f66c49a Fix precompiled 6ad533b Merge pull request #2578 from rkfg/dev 72b4b68 Problem: abort at socket creation on Android with jzmq 8e1facc Merge pull request #2577 from bluca/rep_leak bdc676f Problem: REP leaves label msgs for dead REQ in pipe 766c47f Merge pull request #2575 from zeromq/revert-2572-rep_leak 1489fc1 Revert "Problem: REP leaves label msgs for dead REQ in pipe" 75cc201 Merge pull request #2572 from bluca/rep_leak 0999fdd Problem: REP leaves label msgs for dead REQ in pipe d175819 Merge pull request #2570 from jruffin/master-relicense 30dac38 Added the license grant for jruffin b7e8a3d Merge pull request #2566 from leonarf/leonarf-relicense 7dc06fd license right grant from Leonard Michelet f0df483 Merge pull request #2564 from rotty/master 806bc9d Relicensing grant from rotty fb92cd3 Merge pull request #2562 from pijyoi/fix_init_fdset d11f501 problem: not using official api FD_ZERO to init fd_set 0a66acb Merge pull request #2560 from bluca/tests_ports 18651d1 Merge pull request #2561 from flub/master 3241875 Grant permission to relicense to MPL 655fbfc Problem: ASAN test doesn't print good traces with GCC 4.8 86f9f1d Problem: CI doesn't build with debugging symbols 11e2e5f Problem: address sanitizer support in CI is hacky 6d76106 Problem: test_many_sockets is flacky on OSX 463c2d7 Problem: CI builds and test runs not done in parallel 48792f8 Problem: CI runs libsodium tests b29d46b Problem: tests use same IPC endpoint 5934919 Problem: tests bind to hardcoded TCP ports 2c2c813 Merge pull request #2559 from michicc/master 584706f RELICENSE: Grant from michicc ae461dc Problem: cannot use wildcard port with source address 06666d8 Merge pull request #2558 from bluca/obs_release f126da8 Problem: no way to deploy releases to OBS e24ef3f Merge pull request #2557 from bluca/package_gssapi_manpage d96c48f Problem: OBS _service sets version to unix timestamp.commitid 9dd75e6 Problem: RPM build fails due to ignored zmq_gssapi.7 2215a9d Merge pull request #2554 from bluca/disable_new_poller_without_drafts 90c76fb Problem: new zmq_poller used by zmq_poll without DRAFTs e905f9d Merge pull request #2553 from diorcety/x ec7b948 Fix WITH_DOC 54b8985 Merge pull request #2550 from garlick/gssapi_test edd6b0a gssapi: add a basic test for GSSAPI security 8e33d42 Merge pull request #2549 from garlick/gssapi_nametype 53918fc gssapi: drop unnecessary ifdefs c978d3b gssapi: renumber socket options c23fcc1 Merge pull request #2548 from garlick/gssapi_nametype 568feb1 gssapi: document NAMETYPE options in get/setsockopt(3) 8892087 gssapi: add NAMETYPE options to zmq_getsockopt 9fbf2e2 gssapi: move new options to DRAFT section c49436a Merge pull request #2547 from diorcety/x 17460b3 Targets broken by some parts of f7d1c159d4f96686ce994319280c1bd3a2eab994 7439566 Merge pull request #2546 from rikvdh/master 67eee47 RELICENSE: Grant from rikvdh 4ae2ffd Merge pull request #2545 from garlick/gssapi_nametype 48f7284 gssapi: add zmq_gssapi.7 to MAN7 in Makefile.am 8bd3f03 gssapi: add NAMETYPE socket opts to zmq_gssapi.7 0b185e8 gssapi: add NAMETYPE socket options 4783605 Merge pull request #2544 from Asmod4n/patch-2 798b258 Create Asmod4n.md 4272925 Merge pull request #2541 from garlick/gssapi_fix 2b9a352 gssapi: use gss_buffer_desc consistently 4e22dd0 gssapi: fail if client sets wrong principal f2b579c gssapi: use GSS_C_BOTH to acquire credentials c371824 gssapi: document ZMQ_GSSAPI_PRINCIPAL as optional 43f4c28 gssapi: define HAVE_LIBGSSAPI_KRB5 in configure.ac aa90863 Merge pull request #2539 from juan-filewave/win_build_if_defined_ZMQ_USE_POLL 52ce6aa Problem: Windows build broken by #if ZMQ_USE_POLL ce602d0 change macOS < 10.12 clock to SYSTEM_CLOCK, fixes #2537 (#2538) 45f4a40 Merge pull request #2536 from RPGillespie6/master 69b2aff Add CMake Build Output Options 1d4014d Problem: Minor inconsistency in macro syntax. Solution: Code fixed. (#2534) e8be2e9 Merge pull request #2533 from bjovke/my_work dc7bbe3 Problem: FD set copying on Windows still not optimal on some places. Solution: Improved memcpy() of FD sets for Windows builds. a3ad12f Merge pull request #2532 from bjovke/my_work 6d3d99f Problem: Stack overflow in Windows VS 2012 builds for simple ZeroMQ usage. Solution: Added notice in INSTALL file to mandatory use at least 2 MB stack size in VS 2012 and recommendation to use at least 2 MB in all other Windows builds. eb37793 Merge pull request #2528 from kurdybacha/master 01f8ae0 RELICENSE: Pawel Kurdybacha grant bf07573 Merge pull request #2527 from diorcety/x f7d1c15 Fix windows compilation dfde9a2 Merge pull request #2526 from bjovke/my_work aa3540e Problem: misleading indentation and visually ambiguous if/else block ordering. Solution: fixed indentation and if/else block. c2798ef Merge pull request #2525 from swansontec/master 0b1402f RELICENSE: William Swanson d815228 Merge pull request #2523 from bjovke/my_working_branch 3b01410 Merge pull request #2524 from jakecobb/tcp_codestyle c635ee7 Critical BUG introduced with #2518 fixed. f89e3ee Problem: Bad style in tcp.hpp/cpp 2df4e87 Merge pull request #2522 from bjovke/my_working_branch af6e071 Merge pull request #2521 from jakecobb/windows_tcptuning_consistency cd39b00 Consistency of Windows TCP tuning assertions 9bee9d6 Another macro correction. d66c250 Merge pull request #2519 from bjovke/master b6fb1f6 Macro correction. 2bdd06c Relicense file extensions corrected. 6480721 Merge pull request #2520 from twhittock/patch-1 6ecdd68 Tom Whittock grant 30cd655 Case found not covered in latest zmq::proxy() code. 545cacf Merge pull request #2518 from bjovke/master 26520fe zmq::socket_poller_t speed improvement for constructor and wait() function. a7977a5 Reworked zmq::proxy() for improved performance. 3e55545 Code reformatting of proxy.cpp 2b543e7 Merge pull request #2516 from meox/master c8d6b67 adding licence 6853e3f Merge pull request #2514 from lytboris/freebsd-enable-ai_v4mapped 63e1984 Merge pull request #2513 from lytboris/windows-assign-instead-compare ef8b0c6 re-enable AI_V4MAPPED on FreeBSD & DragonFlyBSD Detect AI_V4MAPPED is not supported in getaddrinfo() on the fly and retry query. This issue was seen on ancient FreeBSD releases and current implementation does support this flag correctly. 2b1bbf1 fix a typo - assigment was used instead of comparison 6a41f27 Merge pull request #2510 from lytboris/ipv6-resolve_nic_name-fix ac7d02e Relicense Grant (#2511) 8bc92bd choose IP(v6) address based on ipv6_ flag in a correct way 9846da0 Merge pull request #2507 from eburkitt/upmaster 9dbf579 Add relicense grant for eburkitt e5583cb Merge pull request #2495 from bluca/relicense_typo c7fea39 Fix asciidoc 238aa49 Merge pull request #2504 from herbrechtsmeier/location 9deb6b0 cmake: Use LOCATION property only for imported targets 96e61d9 Merge pull request #2503 from herbrechtsmeier/msvc 2f367bd cmake: Remove build/msvc include path to remove file name clash 926d2d2 Merge pull request #2493 from herbrechtsmeier/cmake ac92fb5 Merge pull request #2502 from herbrechtsmeier/appveyor abbfed2 appveyor: Use correct CURVE security options cd753ee Merge pull request #2501 from mauri-melato/master 0c2ffd6 RELICENSE: Maurizio Melato grant 84f83d6 Merge pull request #1 from zeromq/master 699b3a2 Merge pull request #2500 from kobolog/kobolog/relicense d0427d1 Relicense. f186421 cmake: Export targets to package config 4e3e3f6 cmake: Disable runtime checks while cross compiling 556de55 cmake: Use project specific source directory instead of top level source tree f5ba27f Relicense bjovke (#2498) 61ba79a Merge pull request #2497 from jakecobb/relicense 33db22c Relicensing permission for Jake Cobb 3458810 Merge pull request #2496 from bbdb68/master 840f726 RELICENSE : Bruno Bodin grant 98dc4a4 Problem: typos in RELICENSE/ptroja.md b26b193 RELICENSE: Piotr Trojanek grant (#2381) 26513b7 Merge pull request #2494 from bjovke/master 319eb27 Unnecessary dynamic memory allocation for zmq::socket_poller_t in zmq_poller_poll(). Fixed by allocating zmq::socket_poller_t from stack. 5d5263e Prevent DOS by asserts in TCP tuning (#2492) 1d58a00 Problem: no windows UWP support e224cc9 Merge pull request #2490 from lodagro/master 9e86341 Merge pull request #2489 from reunanen/relicense dfdd84f Relicense: Wouter Overmeire (lodagro) e1b9dbe RELICENSE: Juha Reunanen / Tomaattinen / Outotec grant c5acd1b Merge pull request #2486 from evoskuil/master 7952c58 Problem: xpub test has broken style (missing whitespace). 1dd9cac Problem: xpub_t.xattach_pipe no handle msg.copy or pipe_t.write fails. 6436bc5 Problem: sub.xsetsockopt leaks message (0..n bytes) payload on fail. 1b79da0 Problem: proxy leaks one message payload (0..n bytes) on close. 4ea7d01 Problem: send_failure() util name undergeneralized (for read success). 8c165ad Problem: excess whitespace (style). d91cd41 Merge pull request #2485 from zeromq/relicense 77562f7 License grant f1bbb6f Merge pull request #2484 from bluca/address_sanitizer d3ca235 Problem: lack of out-of-bound memory checks in tests 7ce68da Merge pull request #2482 from evoskuil/master 0bfd747 Problem: heartbeats test has invalid curve design; xplat and style probs. a014e77 Problem: leaks on send_zap_request fail, use of goto idiom is fragile. 29a5c98 Problem: zap_connect() asserts on write fail (yet returns fail codes). a0ccdc8 Problem: secure servers ignore zap_connect failre code and set ready. 9c6fb09 Merge pull request #2478 from evoskuil/master 6c1fb4d Problem: NuGet pacakge out of date. f44300c Problem: assert used for ZAP error handling aborts process. a6d03df Merge pull request #2477 from zeromq/jemc-relicense a86751b Problem: No relicense file for jemc contributions. 84d94b4 Merge pull request #2475 from chrisstaite/master 5cc487c Relicense grant for chrisstaite 8e2d2d4 Merge pull request #2472 from linville/master 6d739f4 RELICENSE: Aaron Linville grant 815f412 Merge pull request #2471 from t-b/improve_oom_handling 33e29bd Problem: Out of memory condition not always checked fe9f6b2 Problem: GSSAPI check for Out of memory is done conditionally 19f30f7 Problem: throwing version of new called 634c69a Add relicense statement 182cb0e Merge pull request #2470 from ianbarber/master 1f74979 Relicense grant for ianbarber 14bb269 Merge pull request #2469 from madebr/relicense 38e3c12 RELICENSE: Anonymous Maarten grant 5744042 Merge pull request #2468 from goodfella/goodfella-relicensing 0a6f540 RELICENSE: Nick Guiffrida grant 159b39e Merge pull request #2467 from bjoto/master 31a3ead RELICENSE: Björn Töpel / bjoto 8cf64c2 Merge pull request #2466 from evoskuil/master 616fbef Problem: insufficient use of const complicates calling. 7a4c802 Merge pull request #2465 from evoskuil/master fd51347 Merge pull request #2464 from ulikoehler/relicense be94f91 added czmq to permission as well e1cc4cd Added relicense permit feb8e86 Problem: typo in comment. e9e2f8d Merge pull request #2463 from tSed/sma/relicensing 754e9f6 RELICENSE: Samuel Martin grant 9900739 Relicense (#2462) 66accc0 Relicense (#2456) 28cdd11 Allow relicense (#2458) 9221b60 Problem: need to relicense libzmq (#2459) 771b7c6 RELICENSE: Maarten Ditzel (#2460) 85165ba Problem: need to relicense libzmq (#2461) 3f80657 Merge pull request #2457 from evoskuil/master 72714ad Problem: no nuget package for 4.2.2 f2d7b2c Problem: curve not enabled by default in Visual Studio. 91a01f4 Problem: libsodium linked by default in Visual Studio projs. dbb5e72 Problem: Visual Studio projects intertwined and drifting. dbd8346 Merge pull request #2455 from willstrang/master 779561f RELICENSE: William P Strang grant b906f48 Merge pull request #2454 from evoskuil/master 068c815 Problem: __STDC_LIMIT_MACROS before PCH causes VC++ warning. 6622e16 Merge pull request #2451 from evoskuil/master af0320f Problem: implicit cast from size_t to int implies data loss. ded6c84 Merge pull request #2450 from pijyoi/master c796240 RELICENSE: KIU Shueng Chuan 773b8ff Merge pull request #2449 from sdrsdr/sdrsdr-relicense-grant d468e7a Relicense Grant ed6fd03 Merge pull request #2448 from chickenkiller/master 6a87d20 RELICENSE: Lionel Orry grant f82ef5a Merge pull request #2447 from somdoron/gitfoxi-relicense a4e90f6 relicense michael fox 7c58414 Merge pull request #2446 from Hugne/master a898cd3 Relicense: Erik Hugne 04b96ad Merge pull request #2445 from reza-ebrahimi/master c6409b5 Relicense: Reza Ebrahimi <reza-ebrahimi> d0ebd03 Merge pull request #2444 from tabe/relicense-tabe af6293d Merge pull request #2442 from bprager/master 04e4f0f Create BerndPrager.md 6c63f17 RELICENSE: Takeshi Abe 96402a8 Merge pull request #2441 from natano/master d1ce868 Relicense grant: Martin Natano 88d1b86 Relicense - Chuck Remes (#2439) ce4a57f Merge pull request #2440 from fidlej/topic_license 10f591d RELICENSE: Ivo Danihelka grant 9d14c2d Merge pull request #2438 from a4z/authors fcb826f Problem: not on the authors list 98ddc96 Merge pull request #2437 from a4z/relicense 2e564e9 add relicense file 59ecc99 Merge pull request #2435 from Bklyn/master 58bf0dd Relicense: Caleb Epstein (Bklyn) 0d039c9 Merge pull request #2434 from opedroso/master 30ba395 RELICENSE: Osiris Pedroso 895e03e Merge pull request #2431 from robertcastle/master 889fd55 Merge pull request #2433 from SRombauts/master 144c76c RELICENSE: Sébastien Rombauts (SRombauts) 2a2b67c Merge pull request #2429 from cowo78/master a3b8174 Merge pull request #2428 from olafmandel/relicense acd115f Relicense - Robert Castle / Egomotion Ltd 4273383 Merge pull request #2427 from mipaaa/master 45c6ba1 Relicense (#2426) fef3f23 Merge pull request #2430 from roalz/relicense 1f2d5ad Merge pull request #2425 from fichtner/relicense cbd9c00 RELICENSE: Roal Zanazzi (roalz) 1fafe0a Added RELICENSE/GiuseppeCorbelli.md to allow libzmq relicensing 5f09a98 RELICENSE: Olaf Mandel grant c38bf8f Michael Hand grant 4961671 add "any" relicensing permission 27ce7f6 Merge pull request #2424 from gena-moscow/master 607b52f Merge pull request #2423 from aseering/master ed989bf RELICENSE 5d61675 RELICENSE: Adam Seering 1df0de7 Merge pull request #2419 from sheremetyev/relicense bf6656e Merge pull request #2420 from drodri/relicense 123d8a7 Merge pull request #2421 from ezhikus/master c030c6c RELICENSE: Volodymyr Korniichuk 2c9ce72 RELICENSE: Fedor Sheremetyev 5f51911 relicense d80e822 Merge pull request #2418 from djelenc/master 50f8c6d RELICENSE: David Jelenc 09c91ec Merge pull request #2417 from c-rack/relicense-c-rack 730de88 RELICENSE: Constantin Rack d1f5070 Merge pull request #2416 from ghpu/master 59478a8 Agreement to relicensing. 237ad22 Merge pull request #2415 from febeling/copyright-grant d34aa4b RELICENSE febeling 9833d18 Relicense approval (#2397) bf46e30 Merge pull request #2414 from JohanMabille/relicense 949a920 relicense 69038ec Merge pull request #2413 from SylvainCorlay/relicense 45ff021 Relicense 78e4989 Merge pull request #2412 from banburybill/master 85782f3 RELICENSE: Jim Hague 05b6928 Merge pull request #2411 from camachat/master 78b2866 Merge pull request #2410 from soulik/testing 86eed73 RELICENSE: Eric Camachat 5781df5 RELICENSE: soulik ece055a Merge pull request #2409 from danriegsecker/master 68c49b2 Relicense statement for Dan Riegsecker (@danriegsecker) e2e9f7c Merge pull request #2408 from loachfish/master d5e6ec0 RELICENSE: Justin.Hung grant adea1ce RELICENSE: Diego Fons (#2407) e9372f2 Added RELICENSE for amuraru contributor (#2406) 56484e6 Merge pull request #2405 from shripchenko/master 6d4d25a RELICENSE: shripchenko 47c3a6b Merge pull request #2404 from zeromq/gonzus-patch-1 66b7314 Create gonzus.md 9d5b5b7 Merge pull request #2401 from rlenferink/master 2c771a4 Merge pull request #2403 from montoyaedu/patch-1 f6e80e4 Create montoyaedu.md ec14bb7 RELICENSE: Updated wrong filename 89096c7 Merge pull request #2400 from cjuniet/master 88bf9f8 Merge pull request #2399 from sappo/master a2e9ad6 RELICENSE: Christophe Juniet d561143 RELICENSE: Kevin Sapper grant a0d61a8 Merge pull request #2398 from demozon/master 951ba9d Merge pull request #2392 from clkao/patch-1 0793c7a Merge pull request #2396 from vtellier/master 95940fa Merge pull request #2391 from Bitiquinho/master bc7c5a1 Merge pull request #2390 from taotetek/master 7b2ba9f Merge pull request #2389 from johntconklin/relicense 0df66b9 RELICENSE: Tore Halvorsen b121e62 Merge pull request #2395 from ckamm/ckamm-relicense 39407c0 [RELICENSE] Vincent Tellier 0434e03 RELICENSE: Christian Kamm grant 6c42446 Merge pull request #2394 from danielhtshih/master 61cf277 Merge pull request #2393 from evoskuil/master 555f4cc RELICENSE: Daniel Shih grant eb3f007 RELICENSE: Eric Voskuil grant 44a7a3e Create clkao.md 10a39e5 RELICENSE: Leonardo J. Consoni grant 2ac5117 Problem: want to relicense under mplv2 d26414d RELICENSE: John T. Conklin grant 027856d Merge pull request #2385 from rgagnon24/master 2b7cda2 Merge pull request #2386 from jkryl/master 7913e96 I have added msys building, license stuff (#2387) 8ce9a11 Merge pull request #2388 from TTimo/master 7df5373 Merge pull request #2384 from agronholm/master cef0289 relicensing c0ddcf6 RELICENSE: Jan Kryl grant 28e3225 RELICENSE: Robert Gagnon 63120a8 Create agronholm.md 6517d91 Merge pull request #2383 from thompsa/master b9ac5cd RELICENSE: Andrew Thompson grant d4b9065 Merge pull request #2382 from AndreLouisCaron/relicense 625f52e RELICENSE: Andre Caron grant c4d80a5 Merge pull request #2380 from cdolan/relicense eaa77b3 RELICENSE: Christopher Dolan grant 5aab04b Merge pull request #2379 from yuvallanger/master 4ea0dc4 RELICENSE: Yuval Langer grant b43cd5a Merge pull request #2378 from staticfloat/sf/relicensing 4856169 Merge pull request #2377 from tailhook/relicense c33b875 Add relicensing agreement for Elliot Saba 86c7be3 Relicense permission by Paul Colomiets 9091623 Fixed lib and dll paths in visual studio build (#2375) 4cc32d3 Merge pull request #2374 from rlenferink/license_grants a46ca65 RELICENSE: Added templates for relicensing eccf8b7 Merge pull request #2373 from rlenferink/rlenferink_grant bf2b957 RELICENSE: Roy Lenferink grant db85461 Merge pull request #2372 from Q-Leap-Networks/pr-fix_test_sodium 1dd5fef zmq_curve_keypair(): return result from crypto_box_keypair() to make testcase meaningfull da1633e Merge pull request #2368 from bluca/io_thread_name d7aceef Problem: thread name is redundant 092ad50 Problem: I can't refactor 33246f7 Merge pull request #2367 from bluca/io_thread_name 3ab4796 Problem: ZMQ background threads are unnamed 3548d5e Merge pull request #2365 from somdoron/deprecate_zmq_poll aac8bb1 problem:zmq_poll is slow and the API is complicated 580c5b2 Merge pull request #2364 from somdoron/master f694a2d problem: zmq_poll is slow because FD is being created on every call 651f81e Merge pull request #2362 from nexcvon/patch-2 9624f9a Problem: zmq::signaler_t::send may loop forever 70a7756 Merge pull request #2361 from bluca/obs_new 05a967f Problem: Travis using deprecated OBS project 34be53d Merge pull request #2360 from nexcvon/patch-2 bcf7577 Problem: Assertion failed in zmq::signaler_t::send 07d904a Merge pull request #2354 from bluca/fix_pipe a73d5cd Problem: router pipe can block forever 1cfc3e1 Merge pull request #2353 from bluca/fix_test 0f473d1 Problem: unnecessary change to router_mandatory_hwm test ca311f7 Merge pull request #2352 from reza-ebrahimi/master 06740b5 Problem with ZMQ_ROUTER_MANDATORY option when peer lost 995a41b Merge pull request #2350 from tabe/zmq_socket_doc-typo c7ce4a1 Problem: typo in the zmq_socket doc d6f4263 cmake WITH_LIBSODIUM option is broken (#2349) 6818cce Merge pull request #2347 from zstang/patch-1 3b0dfd5 #2341 fix 64a85eb Merge pull request #2346 from bluca/news ac5c75c Problem: 4.2.2 is out, version(s) are out of date 8d75d50 Merge pull request #2345 from bluca/news 5285b6e Problem: packaging versions out of date 854ed90 Problem: NEWS not up to date 26998b7 Merge pull request #2332 from bluca/parse_v4_mapped_in_v6 0db22c0 Merge pull request #2337 from SylvainCorlay/include-find-sodium 33dccd2 Include FindSodium.cmake in dist tarball 18cb7ca Problem: v4-in-v6 mapped addresses cause parsing failure 78dafe5 Merge pull request #2331 from jimklimov/sol-poller f881694 Problem: polling does not work well OOB in OpenIndiana e56bc48 Merge pull request #2327 from chutz/fix-divide-by-zero df7c684 fix divide by zero in zmq::lb_t::sendpipe 5c34f65 Merge pull request #2326 from SylvainCorlay/framework 4e472b1 Make OS Xframwork build optional bf6d8a5 Fix clock_t crash on iOS 9.3.2 and 9.3.5 (#2325) c6c21cf Problem: zmq_z85_decode does not validate its input (#2322) 673bb50 Merge pull request #2318 from kurdybacha/static_file_fix 877419e CMake static library output does not match ZeroMQ Config. c031b0c Merge pull request #2317 from SylvainCorlay/windows-static-target-name e384538 Problem: cmake artefacts different from make generated artefacts e5677d8 Merge pull request #2315 from bluca/typo 5f8d87b Problem: typo in the zmq_has doc 9aae95e Merge pull request #2314 from Asmod4n/master b7cd6e8 add test and documentation for "draft" capability a6a56e2 Merge pull request #2313 from Asmod4n/patch-1 4dbd387 Add "draft" capability to zmq_has 4c1b338 Merge pull request #2311 from SylvainCorlay/static-target-name c65a272 Problem: name of static library generated by cmake differs from the behavior of kernel. ee9751e Merge pull request #2308 from chuggafan/master 020ff65 Updated buildbase and buildall to work with visual studio 2017 f86053b Merge pull request #2304 from JohanMabille/cmake_fix 36d0c70 cmake install on linux fixed b8d8c49 Merge pull request #2302 from laplaceyang/pr_thread_safe_modify_pipe 107f244 Problem: Thread-safe solution for modify hwm of pipe 4fc313d Merge pull request #2301 from bluca/set_peer_unsafe edc770d Problem: HWM always boosted by 1 9f1ba60 Problem: modifying pipe from different thread is not safe 598befc Merge pull request #2299 from laplaceyang/pr_set_hwm_after_connect 5adcb83 Problem: set hwm after connect lead to infinite hwm 77e1792 Merge pull request #2298 from bluca/spec_uuid ce735c4 Problem: spec file still depends on libuuid 81bbd2b Merge pull request #2296 from bluca/asciidoc-base e379366 Problem: debian packages do not build manpages 9dbbd69 Merge pull request #2295 from JohanMabille/cmake_win_install e258890 INSTALLATION instructions 7c709e5 cmake install config file e95d231 CPack option and .txt files installation dir e80db0e Merge pull request #2294 from JohanMabille/cmake_precompiled 2d749a0 Windows cmake build fixed ceb6be7 Merge pull request #2292 from bluca/osx_sigpipe 31a3a06 Problem: peer can close connection before SO_NOSIGPIPE is set d532f2e Merge pull request #2290 from bluca/doc_proxy_eintr 17ef8c6 Merge pull request #2289 from bluca/windoze_includes_test 28c7abf Problem: zmq_proxy* may return EINTR other than ETERM 7e18643 Problem:capitalized include filenames trip mingw dce4d06 Merge pull request #2288 from paddor/master 1b3df75 fix typos ec2ba8a Merge pull request #2283 from vtellier/master ea7e03a Fixed issue #2286 by documentation 7e36db0 Handshake events null pointer fix ffb31dc Fixed issue #2227 second part ee98e7d Merge pull request #2287 from bluca/hurd_ipv6_tos efc0e94 Problem: build fails on GNU/Hurd as it does not support IPV6_TCLASS c38fde0 Merge pull request #2285 from bluca/bump_versions 7c0ded9 Problem: 4.2.1 is out, time to bump versions 7005f22 Bugfix release 4.2.1 086bb89 Merge pull request #2282 from bluca/event_test 3f3601e Problem: handshake events not tested with curve d50b5b8 Problem: NEWS entry for ctx option does not point to docs fc748ec Problem: new monitor events not mentioned in NEWS 200649f Problem: new handshake event monitoring undocumented 2afba00 Problem: documentation does not warn about ZMQ_EVENT_ALL and new events c0e2bc4 Problem: new DRAFT monitor events returned even without --enable-draft 0ebed80 Merge pull request #2281 from vtellier/master 48bc75e Code formatting + reverted hard error handshake fail 0ad600c Merge pull request #2280 from vtellier/master b6e9e0c Fixed issue #2227 64b07d8 Merge pull request #2278 from bluca/msg_t_size_draft 8c22ba2 Problem: bug fixes not mentioned in NEWS file 113feb6 Problem: ZMQ_MSG_T_SIZE draft but not in DRAFT section 715f87f Merge pull request #2277 from bluca/automake_1.14 47c7d8e Problem: debian build fails with automake < 1.14 ef88b8c Merge pull request #2276 from bluca/sodium_pkg bbae5d0 Problem: dpkg-query might fail in CI build and fail the build b2a2bb8 Merge pull request #2275 from bluca/travis_pkg b1137b7 Problem: documentation build not tested on Travis 822def9 Problem: Travis rebuilds libsodium every time a1220b7 Problem: Travis OSX workaround for libtool no longer needed 1f86019 Problem: Travis installs packages when not needed 5871ea5 Merge pull request #2274 from bluca/cloexec 06055a7 Problem: cmake does not run test_zmq_poll_fd 6e708ce Problem: socketpair leaks file on fork+exec f287c7a Problem: eventfd leaks socket on fork+exec 211898d Problem: epoll leaks socket on fork+exec 16439e4 Merge pull request #2272 from bluca/document_read_after_free d68e2e0 Merge pull request #2273 from bluca/docs 3dc016c Problem: no documentation for ZMQ_SOCKS_PROXY baf32a1 Problem: no documentation for zmq_curve_public a06f97d Problem: fix for read-after-free not documented dc39ceb Merge pull request #2268 from imkos/master 4394105 add link libsodium.a edad90f mingw32 fix fe3756d Merge pull request #2266 from Cziken/master ee72493 Problem: Duplicated code 7a8180e Merge pull request #2265 from bluca/contribution_notice_github e6b1f56 Problem: contributing guidelines unclear for new devs 2dec320 Merge pull request #2263 from bluca/revert_curve_break 48e9e24 Problem: #2262 broke curve 2aa09d3 Merge pull request #2262 from Cziken/master 022eeaf Problem: Duplicated code d514bb5 Fixed handling of WSAEWOULDBLOCK to be generic (#2260) 2b56508 Merge pull request #2257 from minrk/check-event 0abdc28 only compare FD when neither item is a zmq socket 1910ef8 Merge pull request #2256 from laplaceyang/pr_zmq4_pub_with_zmtp_v1_sub 02a6079 Merge pull request #2255 from bluca/poll_fd_testcase 8e8fdcc fix bug zmq4.x PUB msg to ZMTP1.0 SUB server 272d340 Problem: no mixed FD and zmq socket zmq_poll test f9d2314 Merge pull request #2251 from hnwyllmm/master a4e448d misuse of 'close' 9052862 Merge pull request #2250 from bluca/poll_regression 72176d5 Problem: check for item.fd causes zloop_poller regression c47e017 Merge pull request #2249 from pavel-pimenov/fix-v817 4d6fbe1 "%" -> '%' 39947d5 Merge pull request #2248 from pavel-pimenov/fix-precompiled eff42fa Add #include "precompiled.hpp" f64d3ad Merge pull request #2247 from bluca/trusty_unwind 379028f Problem: there is no libunwind-dev on Ubuntu 14.04LTS ad4a1bd Merge pull request #2245 from anass-b/builds-vs2017 ad04551 Build support for VS2017, Windows SDK 10.0.14393.0, toolset v141 d407657 Merge pull request #2244 from rotty/wip/fix-mstcpip-include 365ca85 Fix #include case for <mstcpip.h> 519940d Merge pull request #2241 from bluca/aix_test dcec022 Problem: test_stream_exceeds_buffer does not build on AIX 8325355 Problem: test_stream_exceeds_buffer has redundant includes 5e03ad6 Merge pull request #2240 from bluca/aix_poll 57db5f2 Problem: 4.2.0 won't compile on AIX 7.1 3f8e6c0 Merge pull request #2239 from loachfish/master 52ebffd avoid crashing in the multi-thread operation for std::vector 42c6336 Merge pull request #2238 from bluca/revert e46d91d Problem: PR #2236 breaks the build 324f104 Merge pull request #2236 from loachfish/master e1368bd avoid crashing in the multi-thread operation for std::vector 9a20f42 Merge pull request #2235 from bluca/cmake_soversion abeaba1 Problem: CMake build uses library version as the ABI version febf801 bug fix: AIX pollset error (#2233) 294bdb4 Merge pull request #2231 from bluca/windows_ipv6_tos 33fcd2d Problem: Windows does not support IPV6_TCLASS 4a24805 Merge pull request #2225 from bluca/select_broken 121c9d1 Problem: select.cpp/hpp build fails with reorder error ba74890 Problem: cannot pick select for poller e6572fa Merge pull request #2222 from SuperFluffy/doc_explain_context ec25fd2 Add a single sentence explaining what a context is 53bf6df Merge pull request #2221 from minrk/check-socket f302d8a only compare pollitem.fd if pollitem.socket is NULL 185fed3 Merge pull request #2220 from bluca/zmq_msg_size 8a286bb Problem: no documentation for ZMQ_MSG_T_SIZE ctx option b480457 Problem: ZMQ_MSG_T_SIZE is not mentioned in NEWS 670bec5 Problem: size of zmq_msg_t is not known to FFI wrappers 3db6921 Merge pull request #2216 from rotty/master 5d176cb Document terminating NUL behavior in API more explicitly 93ccb5a Merge pull request #2215 from Bklyn/udp-bugfix 10181d7 Untabify 5879f72 Merge pull request #2214 from Bklyn/udp-bugfix f577cea Problem: multicast is spelled incorrectly in udp_address class ace9532 Merge pull request #2213 from Bklyn/udp-bugfix cdac1ac Fix htons copy pasta b9b0fd8 Merge pull request #2210 from bluca/ipv6_tos_v4_only 90f091a Problem: IPV6_TCLASS setsockopt fails on IPv4 socket bc18604 Merge pull request #2209 from saifhhasan/master fc8007e Make ZMQ_TOS work with IPv6 sockets 8ac7500 Merge pull request #2203 from bluca/bump_version e50c6b6 Merge pull request #2206 from bluca/dladdr 1b3fcbd Problem: linker fails looking for dladdr 8015794 Problem: 4.2.0 is out, time to bump version for development 065169a Merge pull request #2201 from bluca/news_blocky 4b58b37 Problem: NEWS says ZMQ_BLOCKY is a sock opt, but it's a ctx opt 067bfa1 Merge pull request #2198 from vyskocilm/master cab901c Problem: linking fails on glibc 2.24 with dladdr missing ef3c259 Merge pull request #2197 from bluca/install_keygen_rpm b73809c Problem: curve_keygen not packaged by RPM spec d9ff348 Merge pull request #2196 from bluca/kfreebsd 43f3cc5 Problem: kFreeBSD does not implement pthread_setschedparam 361e99a Problem: kFreeBSD might return ECONNRESET under load when destroying engine 6585aea Merge pull request #2195 from vyskocilm/master 213a7ef Problem: curve_keygen not build unless --enable-curve is passed 8f57724 Merge pull request #2193 from warriorkitty/patch-1 a5ad378 Fix small typo 42d3ef5 Merge pull request #2192 from bluca/udp_news 7ff6d57 Problem: NEWS says scatter/gather support UDP but they don't 18bd4d1 Merge pull request #2191 from bluca/news_multicast 127ca8b Problem: NEWS does not mention UDP multicast transport 097bf26 Finalize NEWS for 4.2.0 785d9b5 Merge pull request #2189 from bluca/changelog 9e52806 Problem: no NEWS for 4.2.0 932cc82 Problem: NEWS does not include previouos stable releases 7000e84 Merge pull request #2187 from Dmitriy-GH/master 488cb5a MSVC 2015 project for compile libzmq.dll in WinXP compatible mode e7b12b3 Add WinXP compatibility 819bf78 Merge pull request #2186 from bluca/de-draft b5b5f75 Problem: socket option marked as draft for 4.2 8cf4832 Merge pull request #2184 from bluca/rc 6da8385 Problem: new public symbols added e0d6f4e Problem: no NEWS entry for 4.2.0 cc70c82 Merge pull request #2183 from a4z/opmg_cmake 6f597d0 Problem: CMake build rejects to build with openpgm enabled 50a6c11 Merge pull request #2182 from pmienk/master 28fbee7 Suppress warning on uninitialized variable use by initializing variable. fb59cd1 Merge pull request #2181 from jolting/patch-2 60b63ed Remove an unnecessary while (true) 2ece58a Merge pull request #2180 from cxreg/xpub-metadata-corruption b7f2c7e Increment metadata refcount while it's in pending_metadata 16f5847 Merge pull request #2179 from bluca/alignment_windoz 2484d1c Problem: MS VC++ build broken ac14981 Merge pull request #2177 from bluca/alignment df367a6 Problem: pointer union for zmq_msg_t is a hack 0d032c9 Merge pull request #2176 from robertcastle/master 0dfb32a Problem: clock_gettime is now defined in macOS 10.12 SDK 2e92643 Merge pull request #2173 from bluca/without_docs 8345fe9 Problem: build API incompatible with 4.1 1e69309 Merge pull request #2171 from bluca/connect_reuse_addr 25bf30b Problem: 2 connects with same sourceip:port to different destip:port fail 669ff41 Merge pull request #2170 from vielmetti/patch-1 92b1b2b Update INSTALL to note issues with 'make -j check' 1a02b1b Merge pull request #2168 from outotec/fix-build-2 bb7421d Problem: Does not build in Visual Studio 2013 / Win32 d8f55dd Merge pull request #2164 from reunanen/add-EHOSTUNREACH-to-errno_to_string 57c765e Add EHOSTUNREACH to errno_to_string 6ce2fb2 Merge pull request #2162 from hnwyllmm/master c5b528f performance enhancement b031325 Fixed problems from previous PR for #2158 (#2160) 398f256 Merge pull request #2159 from jens-auer/2158 d1c7280 Add mutex for monitor socket 23be1dc Merge pull request #2157 from athampy/master 134f08b Fixed issue #2155 f696290 Implemented network interface name resolution on Windows platform Added fallback mechanism for specific socket binding on Windows platform with IPv6 enabled 3996d4e Merge branch 'master' of github.com:zeromq/libzmq c30da71 Merge pull request #2156 from yasirs/patch-WSL 36af3ed Update tcp_address.cpp 9780945 Merge pull request #2152 from t-b/fix_socket_docu a151ac5 Problem: Invalid markup in zmq_socket.txt 7f8c17b Merge pull request #2150 from bluca/request c592897 Problem: a request 075dd6a Merge pull request #2148 from WGH-/doc-router-mandatory-block eb0e0dd doc/zmq_socket.txt: clarify that ROUTER can be blocking 88e4cff Merge pull request #2147 from goodfella/fix-zmq-poller-poll-return ffdb44a Fix zmq_poll return code assert in tests/test_radio_dish.cpp 1a2d58e Add #ifndef ZMQ_HAVE_WINDOWS guard around unistd.h include f3de534 Do not assign rc to zmq_poller_destroy in zmq_poller_poll f46e45c Include unitstd.h in src/stream_engine.cpp for close system call 6c16693 Merge pull request #2145 from minrk/zmq-poll-repeat fb5a04e allow duplicate entries in zmq_poller_poll ae0676e Merge pull request #2144 from minrk/fix-poller 310dafb zmq_poll returns 0 on timeout 718608c socket_poller::wait returns only triggered events 872f1e5 Merge pull request #2143 from minrk/avoid-duplicate-poller-proxy c636147 avoid duplicate entries in zmq_poll b0df7f1 Merge pull request #2141 from minrk/heap-alloc-poll-events 53fb120 heap-allocate events in zmq_poller_poll 55930f5 Merge pull request #2140 from minrk/zmq_poll_poller c0b1114 Merge pull request #2138 from minrk/darwin-clock 91e121c Merge pull request #2139 from minrk/update-poll-based-on-poll bdcaa93 zmq_poll calls zmq_poller if available e50a987 update socket_poller when ZMQ_POLL_BASED_ON_SELECT 978c5c3 only define clock macros on darwin if not already defined c751899 Merge pull request #2136 from bluca/copyright 2768df8 Merge pull request #2135 from bluca/unbreak-pkg-config 2204cb4 RELICENSE: Brocade Communications Systems Inc. MPLv2 grant 0023941 Problem: Brocade has copyright but not in AUTHORS 06d810b Problem: pkg-config Requires.private is broken 34a1292 Merge pull request #2134 from bluca/pkg-config-static 6d94116 Problem: pkgconfig file does not support static link 131a262 Merge pull request #2131 from minrk/poller-static-2 ec75073 pass through poller events 06aeb47 Merge pull request #2130 from minrk/poller-static-alloc de7fc1f add n_events argument to zmq_poller_wait_all 187b4bf Merge pull request #2128 from minrk/multi-event-poller 2bc9796 Problem: zmq_poller only signals one event 555a087 fix bugs of the pollset (#2127) 113d3ff Merge pull request #2126 from paddor/master 7e07ff3 fix markup syntax on zmq_tipc(7) page 2e55bc5 Merge pull request #2125 from GreatFruitOmsk/master 06614a3 Fix fd_entry may reference invalid object. 22dac19 Merge pull request #2123 from bluca/dealer_router_async ab5c8c8 Problem: zmq_ctx_term segfaults with too many pending inproc connects fab846a Problem: zmq_ctx_term asserts with connect-before-bind and sockets with identity over inproc transport 2540233 Problem: no bind-after-connect TCP test 5524493 Merge pull request #2122 from gena-moscow/master 2e3888d Problem: Pub socket crashes on client disconnect. family_entry.fd_entries [i] is modified in zmq::select_t::rm_fd() Solution: do not copy family_entry.fd_entries [i] e30ab69 Merge pull request #2121 from paddor/master 18e0451 Problem: documentation markup unrecognized bacba21 Merge pull request #2120 from hnwyllmm/pollset bdf887f move macro define `ZMQ_USE_POLLSET` to the position between `ZMQ_USE_DEVPOLL` and `ZMQ_USE_POLL` 5544269 replace tabs with space eee7880 move the `pollset` to the position between `devpoll` and `poll` 861fcaf Merge pull request #2113 from hnwyllmm/pollset c964b7c remove pollset.hpp/.cpp to src directory 4039858 Merge pull request #2112 from hnwyllmm/pollset 3a59711 add pollset poller in AIX 45286fa add pollset poller in AIX 38931b2 add pollset poller in AIX 390e8f4 add pollset poller in AIX 50e277b Merge pull request #2111 from bluca/ipv6_multi_endpoint 53e5a9a Problem: zmq_connect with IPv6 "source:port;dest:port" format is broken c1d07c6 Problem: test_reqrep_tcp does not have IPv6 tests 896192f Problem: test_reqrep_tcp does not test multiple endpoints 75219e3 Problem: test_reqrep_tcp does not test disconnect/unbind 8d723fe Problem: test_reqrep_tcp is too limited f0945c8 Merge pull request #2110 from c-rack/remove-tabs 8cd3333 Problem: source conatins trailing spaces 022cf2a Problem: source code contains tabs e8d665c Merge pull request #2106 from kou/support-mingw-cross-compile da9b954 Problem: MinGW cross compile is failed on Linux 3683a96 Merge pull request #2105 from t-b/bugfix/missing_newline c9c49f3 Problem: Missing newline in printf statement cf34aeb Merge pull request #2100 from a4z/master a43f6ce Problem: scoped optional mutex lock caused unit tests to fail 3068f47 Merge pull request #2099 from a4z/master 9201009 Problem: socket_base uses macros for mutex lock and unlock fb34c32 Merge pull request #2097 from bluca/cmake_dist a4ae43e Problem: CMake build from dist tarball broken ae31587 Merge pull request #2094 from bluca/obs_draft abd3742 Problem: cannot build rpm with drafts on OBS a8a774e Problem: cannot build deb with drafts on OBS 493f17c Merge pull request #2093 from t-b/fix_building_documentation ae08099 Problem: Documentation still has .txt suffix 1303eea Problem: Broken documentation build 81fd404 Merge pull request #2092 from bluca/xp_testutils_ipv6 a9343db Problem: testutil.hpp fails to build on Windows XP 5d1c75f Merge pull request #2090 from jolting/patch-1 fd758d7 [gssapi] memory allocation mismatch on windows 7f8a1da Merge pull request #2089 from bluca/ipv6_test_windows 0002824 Problem: is_ipv6_available needs context to work on Windows f486176 Revert "is_ipv6_available: Create a fake zmq context on windows" aab6ca7 Merge pull request #2088 from t-b/bugfix/initialize_network_stack_for_ipv6_test 9adf20a is_ipv6_available: Create a fake zmq context on windows c9bc939 Merge pull request #2084 from GreatFruitOmsk/cmake-fix 8678fcc Fix compatibility with newer CMake. 8d00cdd Merge pull request #2082 from pijyoi/fix_zmqstream_doc 5340215 Problem: zmq_stream doc is confusing regarding ZMQ_SNDMORE flag 2fc86bc Merge pull request #2074 from bluca/obs_compress ae0ba52 Problem: OBS service changes ver after compress 9029121 Problem: OBS compress not available on CentOS 8454267 Merge pull request #2073 from bluca/obs 6822252 Problem: no OBS service file ce75606 Problem: RPM package does not follow convention 202e7e0 Problem: RPM build targets outdated docs faaa8e5 Problem: RPM has hard-coded SONAME versions c4defc7 Problem: RPM does not support PGM 373b63d Problem: RPM build does not support automake 0372e5c Problem: spec file needs version before build on OBS 9c741c0 Problem: no Debian packaging a7ccb35 Merge pull request #2072 from reza-ebrahimi/master a2db60e Fixing indentation related to commit #2071 e5599de Convert manual (locking and unlocking) mutexes to scoped mutexes for the case of unlocking mutex even if the protected operation throws an exception (#2071) bbece55 Fix copy/paste error (#2070) 61f9e71 Merge pull request #2069 from hjp/master e175fe2 Avoid race condition with accept4 where available 5e68417 Fix build with NORM enabled on FreeBSD. (#2066) 3814b87 Merge pull request #2065 from bluca/osx_sed 531b3bf Problem: Travis CI OSX builds are broken b2e8a90 Merge pull request #2064 from garlick/issue_2051 d090a87 Problem: getifaddrs can fail with ECONNREFUSED d44ef4f Merge pull request #2061 from cowo78/master 7fdb167 [tests/testutil.hpp] Problem: wrong windows.hpp path 0b01cc1 [tests/CMakeLists.txt] Problem: The libzmq.lib search path should be set only if the library is found at a specific path f9c8687 Merge pull request #2054 from BLangpap/master 96c306c Problem: parameter %1 set hard to build target and prevents the skipping of pause Solution: removed Pause d51940a Merge pull request #2053 from BLangpap/master 73631bf modified build.bat to support non-pausing installation 5de974a modified build.bat for msvc to support no-pausing script-based installation 9561cc8 Merge pull request #2046 from pijyoi/reduce_msvc_warnings 603cd1d change event monitoring functions to use zmq::fd_t 5eb6fc3 Merge pull request #2045 from sheremetyev/update-ignores 219f2ff Add missing Git ignores. a1f691e Merge pull request #2042 from sheremetyev/xpub-unsubscribe-manual baea406 Store manual subscriptions in XPUB and send them out on pipe termination. 813c738 Add test for consistent unsubscription in XPUB manual mode. a343059 Merge pull request #2041 from packetstash/select-fix-rebased 4019112 Copy instead of reference to a vector that gets reallocated. b3bfa42 Merge pull request #2036 from aburgm/abort-flush 07a3743 Flush stderr buffer before calling zmq_abort in assert macros 9578245 Merge pull request #2035 from slishak/master d49e43b Problem: FD_SETSIZE not set to 16k for all build definitions cb0eaf6 Merge pull request #2034 from michicc/poll_windows 7a6ff07 Problem: Windows performance is not optimal due to select(). 8d8d32f Problem: Theoretical overflow when polling more than INT_MAX handles. 7292de8 Merge pull request #2031 from bluca/vector_data 0dede9b Problem: std:vector.data breaks compat with C++98 4ea6df4 Merge pull request #2032 from jlblancoc/patch-1 38d7bec Fix build error in MSVC11 dc40c95 Merge pull request #2028 from bluca/update_ndk b4abaad Problem: Android CI uses outdated C++ ABI 4.8 b872e7d Problem: Android CI NDK version out of date 8be5689 Problem: Android CI script hardcodes ABI version 33ed569 Merge pull request #2024 from wbx-github/master 492a035 allow to build sparc (v8,leon) 46912c4 Merge pull request #2023 from jimenezrick/patch-1 c86e07d Problem: update zmq_setsockopt doc with new flag name 2b6200c Merge pull request #2018 from diorcety/mingw64 9835e18 Fix compilation with mingw64 using autotools 7b063a0 Merge pull request #2014 from GreatFruitOmsk/vmci 73e360f VMCI family does not support non-blocking sockets. 184840c Merge pull request #2013 from aseering/master b1e2b87 On systems where getifaddrs() exists but isn't implemented, behave as if 'resolve_nic_name()' were entirely unsupported 9a50364 Merge pull request #2011 from evoskuil/master 96a66ba Problem: msvc imports missing Rule.Category declarations. 5708051 Merge pull request #2008 from hitstergtd/x-fix-windowshpp-style 40a2ed9 Problem: style broken in src/windows.hpp 4cd630f Merge pull request #2004 from evoskuil/master c050d95 Problem: no unit tests for base85 or public curve functions. 5cae5bb Merge pull request #2003 from evoskuil/master 460bc75 Problem: no function to derive curve public key from secret key. 34164ec Merge pull request #2001 from evoskuil/master c7f1673 Problem: unresolved dgram externals in msvc builds. 6a99bb0 Problem: implicit integer narrowing cast warnings. d018029 Merge pull request #2000 from Chris-P-Bacon/patch-1 874c346 Typo in define for libsodium 99373ff Merge pull request #1998 from hitstergtd/x-style-testsrcfd fed1774 Problem: Wrapping issue in test for SRCFD [style] 5f0ac2a Merge pull request #1997 from Bitiquinho/master c1af4fd Add myself to the AUTHORS file d65d15f Merge pull request #1996 from somdoron/udp_raw_sockets bbfed6b problem: memory issues, access uninitiailized memory and leak c7effea Merge pull request #1995 from somdoron/udp_raw_sockets c4d0146 problem: udp doesn't enforce correct usage of bind/connect 443176d Merge pull request #1994 from somdoron/udp_raw_sockets 0db70e2 problem: compilation error on windows d58eb54 problem: test_dgram is missing in .gitignore 55f0a55 problem: dgram is not enforcing two-part message ded0e5a problem: udp_engine didn't work with dgram socket type 6db8f1e problem: test is using connect with dgram, dgram only support bind eb80fa3 problem: dgram more out logic was incorrect 47c0b6e problem: dgram doesn't need to prefetch messages d791932 problem: terminating conn doesn't make sense in disconnected protocol 8cd64b7 Adapt to new draft header. Rebase dgram socket on pair socket 23b3403 Remove printf and add asserts on test 977e700 Fix Copyright range a7399fa Fix Makefile.am da14bb4 Added ZMQ_DGRAM tests to build (Makefile.am and CMakeLists.txt) 94c53e5 Added test for ZMQ_DGRAM socket type (unicast and multicast) cea473d Added ZMQ_DGRAM socket option to precmpiled.hpp 3e54ecd Added dgram.cpp to CMakeLists.txt sources 365c8ed Add dgram_t class (based on stream socket and udp engine) 72f1964 Merge pull request #1992 from evoskuil/master 8474dc3 Problem: precompiled.cpp/hpp required but excluded from non-msvc builds. bd66cfe Merge pull request #1991 from hitstergtd/x-testcov-zmq-2 5939deb Problem: incorrect file extension (.hpp) for zmq_draft.h in Makefile.am. 2b798e4 Problem: name conflicts from windows.h, draft API declared in pch. bda9374 Problem: inadvertently deployed nuget package without tweetnacl enabled. a3aa10c Problem: nuget packaging script doesn't pause at the end. 94774f6 Merge pull request #1988 from evoskuil/master 5e0fb27 Problem: tab characters are poor for source readability. af524ae Problem: msvc dist has redundancies and missing elements. 9e26bb1 Problem: typo in platform.hpp comment. 1c9d02d Problem: mo current nuget package. 7684ce4 Problem: incorrect white spacing for standard vcxproj file. 9622a83 Problem: inapplicable, redundant and invalid references in msvc pch. 4b041ef Problem: nuget package using wrong symbol and configured for libsodium. 2113fee Problem: msvc precompiled header config is a mess, tweetnacl is missing. 0db0739 Problem: msvc configuration options are invalid and/or inconsistent. 01ab149 Problem: copy of libsodium import props is unnecessary. 7425fcc Problem: incorrect include guard symbol. 40d7a4c Problem: redundant copies of msvc .props and .xml files. 71ba7df Merge pull request #1987 from hitstergtd/x-reduce-cliserv-sends e82e4ea Problem: test send count too high for AppVeyor f25a13b Problem: configure.bat is incomplete and conflicts with MSVC UI. 9e872d0 Merge pull request #1984 from hitstergtd/x-testcov-zmq-ctx 477cc1c Problem: zmq_poller_destroy parameter checking 4842b6b Problem: No coverage for ctx termination errors f8c93d5 Merge pull request #1983 from hitstergtd/x-unused-thread e946b0d Problem: scheduling parameters unused on OSX bce1cf9 Problem: vc common props have platform specific conditions. a3c3bcf Problem: visual c++ invalid ToolsVersion warnings. 9cb7077 Problem: inconsistent msvc property sheet display name (vs2012). b5342bc Problem: no tool for maintainers to build all vs solutions. 398a5fd Problem: vs2010/12 build breaks, exclude atomic & inttypes in msvc pch. 29c8e30 Merge pull request #1982 from Hugne/bug_1968 f81ef1b tipc: add support for address domain suffix 4ad68e0 Merge pull request #1981 from hitstergtd/x-unused-req 10a84ac Merge pull request #1979 from dmillard/patch-1 9e6745c Fix autotools for static MinGW builds c7ecbed Merge pull request #1977 from hitstergtd/x-unused-variables 5efa118 Problem: hint parameter throws unused warning 545e8e8 Problem: sockfd_ parameter throws unused warning dc72965 Merge pull request #1976 from zeromq/revert-1975-master c41d514 Revert "problem:Socket try to access closed mutex" f6ce1d7 Merge pull request #1975 from somdoron/master 77d3d7b problem:Socket try to access closed mutex a6e8d15 Merge pull request #1974 from hitstergtd/master 8fc985a Problem: style/typo issue a4a247c Merge pull request #1973 from hitstergtd/x-fix-m4-llvm-gcov-coverage 3eef0a7 Merge pull request #1972 from hitstergtd/x-stylefix-udpengine 415af27 Problem: Coverage option broken with LLVM GCOV 1f309d3 Merge pull request #1971 from sappo/master b225581 Problem: Deploying release artifacts is a manual process Solution: Use travis to deploy these artifacts automatically. c4ce6d9 Merge pull request #1970 from hitstergtd/x-add-ancillary-tests 124ebd2 Problem: UDP engine code not indented properly 206771a Problem: Not all ancillary API methods tested d6aa6e7 Merge pull request #1969 from pijyoi/fix_invalidsocket bb4bcf8 fix: sockets are not signed int on Windows f88d129 Merge pull request #1966 from bluca/backtrace_assert bb5037e Problem: leftover commented out line in configure 8045e9a Problem: no backtrace is printed on assert c1dc9d0 Merge pull request #1967 from hitstergtd/x-add-militant-option 6ea9dbc Problem: No CMake option to set ZMQ_ACT_MILITANT f98b5bb Merge pull request #1964 from bluca/sock_close_read_after_free 17132f0 Problem: read-after-free when closing socket e9380b5 Merge pull request #1962 from somdoron/master be741f6 problem: timers test is flapping on windows 5dadded Merge pull request #1961 from somdoron/Signaler a747f72 problem:closed poller still associated with socket fb75b20 Merge pull request #1960 from hitstergtd/x-sort-AUTHORS 001ddd8 Merge pull request #1958 from hitstergtd/x-deprecate-zmq-sendrecviov-fix a46d7b9 Merge pull request #1959 from hitstergtd/x-zmqpoll-fix b3bb0b7 Problem: zmq_sendiov/zmq_recviov not Deprecated 109122d Problem: style issues with comment in zmq_poll c33e96f Merge pull request #1957 from hitstergtd/x-TIPC-CMake-fix b470ed4 Problem: ZMQ_HAVE_TIPC option for CMake is broken 00d7ee1 Merge pull request #1956 from hitstergtd/x-addto-AUTHORS-file ad82bd1 Merge pull request #1955 from hitstergtd/x-remove-MAINTAINERS-file 6ae2ff6 Problem: MAINTAINERS file has no purpose anymore 745e07d Merge pull request #1954 from somdoron/master e15da4b problem: compilation error on osx feec476 Merge pull request #1953 from somdoron/master ba20f66 problem: SRCFD is redundant as we have metadata 4012538 problem: srcfd is broken a192663 Merge pull request #1951 from hitstergtd/x-monitorcomment-fix 372ab4b Merge pull request #1949 from somdoron/master 50c2f7a fix sndbuf/rcvbuf tests fca4592 problem: zeromq performance got worsen by some changes 115e7de Merge pull request #1948 from hitstergtd/x-gitignore-fix e68c8ae Problem: Not all GCOV extensions in .gitignore fc7d5e7 Merge pull request #1946 from somdoron/master b3667cc mark zmq_msg new methods as draft fcc80d4 add draft option to windows configure 91394d2 Merge pull request #1945 from bluca/draft_api b741350 Problem: test_pub_invert_matching not ignored a782be7 Problem: no CI tests with DRAFT enabled 6de24c1 Problem: scatter/gather are not yet stable APIs caaf66c Problem: radio/dish are not yet stable APIs 32a1ef8 Problem: zmq_timers* are not yet stable APIs 7389680 Problem: zmq_poller* are not yet stable APIs 7e700f1 Problem: client/server are not yet stable APIs 064cd1f Problem: no support for DRAFT API in build systems f0a34e0 Problem: test_poller/use_fd_ipc/tcp use draft API c293618 Problem: testutil.hpp includes platform.hpp last b469832 Problem: precompiled.hpp ifdef'd for windows 464d3fd Merge pull request #1944 from hitstergtd/x-testmonitor-fix b65fc90 Merge pull request #1943 from hitstergtd/x-style-tunetcpkeepalives-fix dc81aac Merge pull request #1940 from hitstergtd/x-update-autoconf-archive-m4-macros 52871b0 Problem: autoconf-archive m4 macros out of date a8f7561 Merge pull request #1941 from hitstergtd/x-doc-setsockopt-fix 1ab7dd0 Problem: supported protocols comment is stale 40dbbe3 Problem: bounce() arguments reversed 4809926 Problem: zmq_setsockopt(3) man page formatting b3ae7cf Merge pull request #1937 from hitstergtd/test-add-sendiov e453977 Problem: multiple issues with sendiov/recviov a31c508 Problem: tune_tcp* related code has style issues 89ef8b3 Merge pull request #1938 from hitstergtd/decoder-fix d7038bf Problem: AUTHORS file is not sorted 56e83d0 Problem: Not shamelessly plugged into AUTHORS 8820e35 Problem: style issues in decoder.hpp 95acb29 Merge pull request #1934 from somdoron/master fee8413 UDP and Radio-dish documentation 34d5028 allow specify binding address on radio with udp 9ec9c4a Merge pull request #1933 from sappo/master a1ee5e3 Problem: relicense statement from imatix is in the wrong place Solution: move the statement to the folder introduced in commit: dd51cad082923a5973cdaff9c0418e5ab28de763 5264a9a Merge pull request #1917 from hintjens/master c1155fa Merge pull request #1925 from ewen-naos-nz/ewen_mcneill_relicense_naos f64c842 Merge pull request #1924 from ewen-naos-nz/ewen_mcneill_relicense_readme f7cf246 Merge pull request #1932 from hitstergtd/doxygen-libzmq f950f2b Problem: No default doxygen cfg for ZeroMQ project 6712f6d Merge pull request #1931 from hitstergtd/unistd-fix e604bbc RELICENSE: Link to 0MQ Licensing page 3df0a4f Merge pull request #1929 from hitstergtd/autotools-fix 9218441 Problem: unistd.h redundantly included twice 876ee5d Problem: test_pub_invert_matching missing in autotools build 4b3199f Merge pull request #1927 from hitstergtd/codespell-fixes af82d06 Merge pull request #1926 from hitstergtd/codespell-fixes d3c800a Problem: tune_tcp_keepalives signature >80 chars b2d0ab1 Problem: trailing whitespace in code 11311f9 Problem: trailing spaces in code comments a4b426b Problem: typos/trailing spaces in code comments 0e5ea0c RELICENSE: Naos Ltd MPLv2 grant dd51cad RELICENSE: Start collecting MPLv2 license grants 7b9005a Merge pull request #1923 from hitstergtd/testxpubmanual-msvc-fix 8872809 Problem: XPUB test broken since #1566 on Windows fb01556 Merge pull request #1921 from somdoron/master 9798f74 add have timers define to detect if timers class available a4d219c Problem: need to collect grants to relicense under MPLv2 230df28 Merge pull request #1920 from somdoron/master 0655ed2 fix test unbind wildcard 0934bc7 fix test term endpoint 6f1dc64 Merge pull request #1919 from bluca/xpub_test_logic a936003 Problem: assertion in test_xpub_manual is swapped dd038ae Merge pull request #1918 from hitstergtd/hitstergtd-testxpubmanual-win ff02862 Problem: XPUB test broken on Windows since #1569 4ae62df Merge pull request #1916 from linville/master a57fd70 Fix issue with unresolved external symbols for the gather and scatter classes by adding them to the MSVC 2010, 2012, 2013 and 2015 projects. ad4e091 Merge pull request #1915 from hitstergtd/checkproto-windows-fix 7feb1e4 Problem: Windows IPC check broken (check_protocol) 0ece425 Merge pull request #1914 from hitstergtd/clang-testfiles-fix 7f0e380 Problem: LD search path warnings if using Clang 23e4252 Merge pull request #1913 from bluca/ipc_windows 5178251 Problem: test_ipc_wildcard is ran on Windows d6a57ad Merge pull request #1912 from hitstergtd/hitstergtd-testsrcfd-win-fix e8aeb36 Problem: ZMQ_SRCFD test does not work on Windows 99763cc Merge pull request #1909 from somdoron/master e6dae56 Scatter-Gather socket types fae3a4e Merge pull request #1911 from somdoron/FixUDPWindows bf50f9f Merge pull request #1910 from bluca/tipc 87e455f Fix UDP failing on windows a117c1f Problem: Travis CI CMake build does not run tests ea294af Problem: CMake does not check for TIPC support 317499e Merge pull request #1906 from hitstergtd/hitstergtd-cmake-tests-os-fix 846b2ba Problem: Linker search path warnings on OS X 136870f Merge pull request #1902 from bluca/zmq_unbind_api_breakage c8211bf Problem: can't unbind with bound addr with IPv6 58c4e7e Problem: IPv6 is disabled on Travis Precise/Trusty ac0e97e Problem: can't test if IPv6 is available in tests 8d49650 Merge pull request #1901 from hitstergtd/hitstergtd-testcmake-fix e09eb0d Problem: comment not well formed in CMakeLists.txt 1d083a3 Merge pull request #1900 from hitstergtd/hitstergtd-testudp-fix 9a9bfb6 Problem: test_udp does not release resources properly c354e0b Merge pull request #1898 from hitstergtd/checkprotocol-fixes-1 8cb2731 Problem: check_protocol() logic duplicated twice a670e81 Merge pull request #1897 from hitstergtd/udp-errno-fix 3623779 Problem: errno not set if UDP is NOT used with ZMQ_RADIO or ZMQ_DISH c2a1be5 Merge pull request #1896 from hitstergtd/macosx-testfixes-1 307bd95 Make all Linux-specific tests conditional 8c88297 Merge pull request #1895 from hitstergtd/libzmq-docfixes-2 a17389e Fix typos similar to #1894 6a7eb2f Merge pull request #1894 from hitstergtd/libzmq-docfixes-1 6c31292 Fix typo 3f77cf5 Merge pull request #1892 from bluca/solaris_fixes f6f89a8 Merge pull request #1893 from paddor/master ba9a559 Problem: PR #1891 wasn't complete 1afed1d Problem: tabs instead of spaces used for indentation b1232a0 Problem: Solaris build fails with libsodium a01baba Problem: test_use_fd_tcp does not work on Solaris edda165 Problem: pragma diagnostic is new in GCC 4.2 abe4450 Problem: tweetnacl does not build on Solaris 10 c54589d Merge pull request #1891 from paddor/master 621c965 Problem: tricky return value from zmq::socket_poller_t::wait when poller is empty b5dc794 Problem: zmq_poller_wait doesn't check *event arg d570f57 Problem: ipc://* random dir created with USE_FD f18463f Problem: mkdtemp not available on all platforms 8028817 Problem: 1E9 is double but assigned to an int var 32f2b78 Merge pull request #1889 from spadalkar/master e3016b6 Fix tests/test_many_sockets.cpp 23d08c2 Merge pull request #1888 from bluca/ipv6_downgrade 9cf6f85 Problem: redundant Windows errno conversion 99a8795 Problem: zmq_connect (TCP) has no IPv4 fallback d169281 Problem: zmq_bind IPv4 fallback still tries IPv6 8251306 Merge pull request #1885 from jimklimov/zmq_utils_header d7d9171 Problem: including recent "zmq_utils.h" crashes gcc -pedantic jobs fb4c226 Merge pull request #1884 from hintjens/master 9eb74d4 Problem: ZMQ_SERVER man page is wrong aa13a49 Merge pull request #1883 from yuvallanger/master 37a4a40 Fix NetBSD thread scheduling problem. 7a563eb Merge pull request #1882 from FredTreg/master 625b618 Fixed ZMQ_REQ_CORRELATE (see pull request #1730) 0feec7a Merge pull request #1881 from camachat/master 023b34a Fix issue #1419 segfault when using a XSUB/XPUB proxy. Ref. https://github.com/zeromq/libzmq/issues/1419 a7922e5 Merge pull request #1880 from MatthewPowley/fix-windows-xp-compatability f2018ab Fixes for Windows XP compatibility dac5b45 Merge pull request #1879 from MatthewPowley/improve-msvc-builds 260860d Add .gitignore for Visual Studio builds in the 'builds/msvc' folder 0e405a5 Use vs2015 MSBuild property sheets in older projects cddfda2 Merge pull request #1875 from hintjens/master e70e39b Problem: ctx.cpp still uses old HAVE_LIBSODIUM d6354c6 Merge pull request #1874 from hintjens/master 396237f Problem: MSVC builds instructions aren't entirely clear 6a78b3e Problem: HAVE_LIBSODIUM macro is inconsistent 6630a7c Merge pull request #1873 from edigaryev/fix-urandom-chroot 8673fa7 Problem: build fails when CURVE security is disabled c71bb5f Merge pull request #1872 from edigaryev/fix-urandom-chroot 884e00c Problem: CURVE mechanism is unusable with chroot() c39741d Merge pull request #1871 from gnieboer/gnieboer-patch-1 8c7b19b Update zmq_utils.h 05c8de7 Merge pull request #1869 from jimklimov/fix-tcp_address e9c8557 zeromq-4.1.4/src/tcp_address.cpp : fix relaxed use of sizeof() without parenthesis b8ae850 Merge pull request #1862 from FredTreg/master e45dfe3 Fixed issue #1695 (ZMQ_REQ_CORRELATE) 98ab7f4 Merge pull request #1860 from bluca/valgrind dc27ad4 Problem: coveralls uses wrong path on Trusty 0eca822 Problem: Valgrind in Ubuntu Precise is too old 9d94eb1 Problem: test_fork causes valgrind false positive 00e0957 Problem: false positive on valgrind 3.10 ebc7316 Problem: CI doesn't run Valgrind 2b2f904 Problem: no Makefile target for Valgrind d5aaaeb Merge pull request #1859 from soulik/master 75579fe Added comment to sockaddr_storage e38166c Use sockaddr_storage instead of sockaddr to support IPv6 addresses 3777309 Merge pull request #1858 from zoobab/master 516efa4 add some doc for docker android compilation 340eb52 Merge pull request #1847 from bluca/test_large_msg 9a3c9ff Merge pull request #1857 from Suudy/master 075de03 Use FILENAME_MAX to determine BUFSIZE when getting socket path. 15fd419 Problem: test_large_msg requires 2GB of free RAM de56bc2 Merge pull request #1853 from bluca/osx_ipc_wildcard 11917f8 Problem: IPC wildcard test broken on OSX 5ce6bc5 Merge pull request #1852 from Suudy/master b6080a7 Updated handling of Unix Domain Sockets, make use of temporary directories, and cleanup afterward. Fix test_term_endpoint handling of optvallen 96c9e4a Merge pull request #1851 from bluca/gcov 1ac71c3 Problem: no coveralls.io badge in README.md 0cd7c0f Problem: no code coverage in CI 6df753c Problem: no code coverage integration 22cb66d Merge pull request #1849 from opedroso/WINPDB a6392b9 Problem: Windows PDB not created for RELEASE targets dbb6b01 Merge pull request #1848 from benjamg/benjamg-patch-1 7cc50d0 parameter naming consistency [aesthetic] 24d12dc Merge pull request #1827 from bluca/make_dist_missing_files 6aa5819 Merge pull request #1845 from claudioscordino/master cb1b6bc Better comments for understanding the classes array_t<> and array_item_t<> 6024dd5 Problem: ci_build does not fully test build system ff1ebf6 Problem: ci_build.sh make check is overly complex 4366d7e Problem: doc/Makefile.am ignores --without-docs 2d9e7b5 Problem: make dist does not tar up macros.hpp 8a0a18a Merge pull request #1844 from opedroso/CMAKELIST_PRECOMP cd1dfb4 Problem: CMakelist missing support for Windows Precompiled headers 2cd4c38 Merge pull request #1843 from opedroso/WINDOWS_MAKE_TEST 1c9cec2 Problem: Tests do no build in Windows environment a911fa4 Problem: Tests do no build in Windows environment 0916c17 Merge pull request #1842 from opedroso/PRECOMPILED 72898a0 Merge pull request #1841 from opedroso/MAKE_CLEAN 224c067 Problem: Windows Build not using precompiled headers for all targets 09d003a Problem: Added "make clean" to Windows build scripts d315eea Merge pull request #1839 from opedroso/master ee31ea1 Merge pull request #1838 from obache/neatsrc/fix-c-comment-style 693d638 Merge pull request #1837 from obache/neatsrc/fix-test-portability 3c4377b Merge pull request #1836 from obache/neatsrc/heimdal 8c7c8ec Problem: Fix C++ style comment usage in C source 55dad06 Problem: Fix unportable `==` operator for `test` 09e868b Problem: Fix build with Heimdal krb5 36abdf7 Merge pull request #1834 from garlick/config_nacl 54389fe Problem: AS_HELP_STRING improperly quoted 9d75a9c Problem: AM_CONDITIONAL is used incorrectly ec62097 Merge pull request #1832 from hintjens/master 5b7bf75 Problem: can't be sure crypto_box always returns 0 708c206 Merge pull request #1830 from stevenc99/master dd8ccd5 include sys/ucred.h for struct ucred d769175 Merge pull request #1829 from dflupu/master 3190de8 update Makefile.mingw32 8b32073 Merge pull request #1826 from bluca/make_dist b3b9cfd Problem: packaging/redhat/zeromq.spec not ignored f3686e3 Problem: make dist broken due to builds/msvc 3913975 Problem: make dist broken due to builds/android 8d81147 Problem: make dist broken due to builds/cmake 232094a Merge pull request #1825 from bluca/whitespace_and_werror 80e529a Problem: all tests fail with assert in in_event ae8efc2 Problem: nullptr is a reserved keyword in C++0x 7187169 Problem: socket_poller_t initialization reorder c84a52b Problem: udp_engine_t fd cannot be init to NULL 1046f35 Problem: udp_engine_t initialization reorder 24b8408 Problem: socks_connecter_t initialization reorder a6e4986 Problem: tcp_connecter_t initialization reorder 645c2be Problem: stream_engine_t initialization reorder c21dd8d Problem: socket_base_t initialization reorder acbf021 Problem: reaper_t initialization reorder 779bed6 Problem: encoder_base_t initialization reorder de46fc6 Problem: can't do anything with load.sub ret val 14054d2 Problem: can't statically initialized pthread_t cf309a4 Problem: maxfd definition depends on ifdef d4c0716 Problem: indentation should be 4 spaces, no tabs 406b573 Merge pull request #1823 from opedroso/COVERITY b3d5fa6 Problem: Several problems found by Coverity Static Analyzer 4fca95a Problem: Visual Studio Toolset was incorrectly set in VCXPROJ files 1ffd874 Merge pull request #1822 from opedroso/VS_…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ticket:4896.