Skip to content

Commit b66d30c

Browse files
committed
Test the OMEdit diagrams
Renamed RunOMEditTestsuite to RunOMEditTestsuite.sh Merged the browsing tests
1 parent 1694d34 commit b66d30c

File tree

11 files changed

+47
-16
lines changed

11 files changed

+47
-16
lines changed

.CI/common.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ void buildAndRunOMEditTestsuite(stash) {
258258
echo export OPENMODELICALIBRARY="\${MSYS_WORKSPACE}/build/lib/omlibrary"
259259
echo time make -f Makefile.omdev.mingw \${MAKETHREADS} omedit-testsuite
260260
echo cd build/bin
261-
echo ./RunOMEditTestsuite
261+
echo ./RunOMEditTestsuite.sh
262262
) > buildOMEditTestsuiteWindows.sh
263263
264264
set MSYSTEM=MINGW64
@@ -280,7 +280,7 @@ void buildAndRunOMEditTestsuite(stash) {
280280
sh "${makeCommand()} -j${numPhysicalCPU()} --output-sync omedit-testsuite" // Builds the OMEdit testsuite
281281
sh label: 'RunOMEditTestsuite', script: '''
282282
cd build/bin
283-
xvfb-run ./RunOMEditTestsuite
283+
xvfb-run ./RunOMEditTestsuite.sh
284284
'''
285285

286286
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
include(../Common/Testsuite.pri)
3232

33-
TARGET = BrowseElectricalAnalogBasic
33+
TARGET = BrowseMSL
3434

3535
SOURCES += ../Common/Util.cpp \
3636
Test.cpp

OMEdit/Testsuite/BrowseMediaAirReferenceMoistAir/Test.cpp renamed to OMEdit/Testsuite/BrowseMSL/Test.cpp

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,27 @@ extern "C" {
4545

4646
OMEDITTEST_MAIN(Test)
4747

48-
void Test::testcase()
48+
/*!
49+
* \brief Test::electricalAnalogBasic
50+
* Browses the Modelica.Electrical.Analog.Basic
51+
*/
52+
void Test::electricalAnalogBasic()
53+
{
54+
if (!Util::expandLibraryTreeItemParentHierarchy(MainWindow::instance()->getLibraryWidget()->getLibraryTreeModel()->findLibraryTreeItem("Modelica.Electrical.Analog.Basic"))) {
55+
QFAIL("Expanding to Modelica.Electrical.Analog.Basic failed.");
56+
}
57+
MainWindow::instance()->close();
58+
}
59+
60+
/*!
61+
* \brief Test::mediaAir
62+
* Browses the Modelica.Media.Air
63+
*/
64+
void Test::mediaAir()
4965
{
5066
OMEDITTEST_SKIP("Enable this testcase by removing this line once the ticket#5669 (https://trac.openmodelica.org/OpenModelica/ticket/5669) is fixed.");
5167
if (!Util::expandLibraryTreeItemParentHierarchy(MainWindow::instance()->getLibraryWidget()->getLibraryTreeModel()->findLibraryTreeItem("Modelica.Media.Air"))) {
52-
QFAIL("");
68+
QFAIL("Expanding to Modelica.Media.Air failed.");
5369
}
5470
MainWindow::instance()->close();
5571
}

OMEdit/Testsuite/BrowseMediaAirReferenceMoistAir/Test.h renamed to OMEdit/Testsuite/BrowseMSL/Test.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ class Test: public QObject
4242
Q_OBJECT
4343

4444
private slots:
45-
void testcase();
45+
void electricalAnalogBasic();
46+
void mediaAir();
4647
};
4748

4849
#endif // TESTGUI_H
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
include(../Common/Testsuite.pri)
3232

33-
TARGET = BrowseMediaAirReferenceMoistAir
33+
TARGET = Diagram
3434

3535
SOURCES += ../Common/Util.cpp \
3636
Test.cpp

OMEdit/Testsuite/BrowseElectricalAnalogBasic/Test.cpp renamed to OMEdit/Testsuite/Diagram/Test.cpp

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,24 @@ extern "C" {
4545

4646
OMEDITTEST_MAIN(Test)
4747

48-
void Test::testcase()
48+
/*!
49+
* \brief Test::chuaCircuit
50+
* Browses to Modelica.Electrical.Analog.Examples.ChuaCircuit and loads it diagram view.
51+
*/
52+
void Test::chuaCircuit()
4953
{
50-
if (!Util::expandLibraryTreeItemParentHierarchy(MainWindow::instance()->getLibraryWidget()->getLibraryTreeModel()->findLibraryTreeItem("Modelica.Electrical.Analog.Basic"))) {
51-
QFAIL("");
54+
LibraryTreeItem *pLibraryTreeItem = MainWindow::instance()->getLibraryWidget()->getLibraryTreeModel()->findLibraryTreeItem("Modelica.Electrical.Analog.Examples.ChuaCircuit");
55+
if (!pLibraryTreeItem) {
56+
QFAIL("Failed to find Modelica.Electrical.Analog.Examples.ChuaCircuit. Makesure MSL is loaded.");
57+
}
58+
if (!Util::expandLibraryTreeItemParentHierarchy(pLibraryTreeItem)) {
59+
QFAIL("Expanding to Modelica.Electrical.Analog.Examples failed.");
5260
}
61+
62+
// Open the Modelica.Electrical.Analog.Examples.ChuaCircuit diagram.
63+
QModelIndex modelIndex = MainWindow::instance()->getLibraryWidget()->getLibraryTreeModel()->libraryTreeItemIndex(pLibraryTreeItem);
64+
QModelIndex proxyIndex = MainWindow::instance()->getLibraryWidget()->getLibraryTreeProxyModel()->mapFromSource(modelIndex);
65+
MainWindow::instance()->getLibraryWidget()->getLibraryTreeView()->libraryTreeItemDoubleClicked(proxyIndex);
66+
5367
MainWindow::instance()->close();
5468
}

OMEdit/Testsuite/BrowseElectricalAnalogBasic/Test.h renamed to OMEdit/Testsuite/Diagram/Test.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class Test: public QObject
4242
Q_OBJECT
4343

4444
private slots:
45-
void testcase();
45+
void chuaCircuit();
4646
};
4747

4848
#endif // TESTGUI_H

OMEdit/Testsuite/Makefile.omdev.mingw

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ mkbuilddirs:
2222

2323
install: build
2424
cp -p ../bin/tests/*$(EXE) $(builddir_bin)
25-
cp -p RunOMEditTestsuite $(builddir_bin)
25+
cp -p RunOMEditTestsuite.sh $(builddir_bin)
2626

2727
build: Makefile
2828
$(MAKE) -f Makefile

OMEdit/Testsuite/Makefile.unix.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ QMAKE=@QMAKE@
44

55
install: build
66
cp -p ../bin/tests/* @OMBUILDDIR@/bin
7-
cp -p RunOMEditTestsuite @OMBUILDDIR@/bin
7+
cp -p RunOMEditTestsuite.sh @OMBUILDDIR@/bin
88

99
build: Makefile OMEditGUI.unix.config.pri
1010
$(MAKE) -f Makefile

OMEdit/Testsuite/RunOMEditTestsuite renamed to OMEdit/Testsuite/RunOMEditTestsuite.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/bin/bash
22
set -e
33

4-
testcases=( "BrowseElectricalAnalogBasic" "BrowseMediaAirReferenceMoistAir" )
4+
testcases=( "BrowseMSL" "Diagram" )
55
OMEditTestResults="$PWD/OMEditTestResult"
66

77
for i in "${testcases[@]}"

OMEdit/Testsuite/Testsuite.pro

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@
3030

3131
TEMPLATE = subdirs
3232

33-
SUBDIRS = BrowseElectricalAnalogBasic \
34-
BrowseMediaAirReferenceMoistAir
33+
SUBDIRS = BrowseMSL \
34+
Diagram
3535

0 commit comments

Comments
 (0)