send situations to the datalake when accepted, add alarm(s), remove a… #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…larm(s) add unit test
BenjaminJ
requested review from
amay94,
aramosvizcarra,
fooker,
freddy61025 and
geraldhumphries
j-white
reviewed
Dec 5, 2022
features/ui/src/main/java/org/opennms/alec/rest/SituationRestImpl.java
Outdated
Show resolved
Hide resolved
j-white
reviewed
Dec 7, 2022
features/ui/src/main/java/org/opennms/alec/grpc/SituationClient.java
Outdated
Show resolved
Hide resolved
features/ui/src/main/java/org/opennms/alec/grpc/SituationClient.java
Outdated
Show resolved
Hide resolved
features/ui/src/main/java/org/opennms/alec/grpc/SituationClient.java
Outdated
Show resolved
Hide resolved
features/ui/src/main/java/org/opennms/alec/grpc/SituationClient.java
Outdated
Show resolved
Hide resolved
initialize mapper in SituationClient sendSituation can return void initialize channel only if the user opted-in
update guava version
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>30.1.1-jre</version> |
There was a problem hiding this comment.
You should pull this version number up into a property or into dependencyManagement.
| client = new SituationClient(canWeStore(kvStore), grpcConnectionConfig); | ||
| } | ||
|
|
||
| //Only for testing |
There was a problem hiding this comment.
I see that this constructor only exists so we can mock SituationClient in the unit tests. Does it make sense for SituationClient to be converted into a bean, and injected directly? That would probably be cleaner, but it would need some refactors and I'm not sure about the implications regarding the number of SituationClients we need to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send situations to the datalake when situation is created,accepted or modified
also fix feedback for rejected situation
add unit test
use async client